Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added link to netcat official site and '-v' key to netcat command example #44600

Merged

Conversation

ksemele
Copy link
Contributor

@ksemele ksemele commented Jan 1, 2024

Hello!
I added link to netcat official site and a very useful key -v at example command.

Why did I add this?

  1. My installation did not include netcat out of the box and I had to search for what was meant.
  2. When running the example as is (without an additional key) - it is absolutely unclear what is happening.

Example output of the command without a key, if the port is unavailable:

$ nc 127.0.0.1 6443

Example of command output with key, if port is unavailable:

nc 127.0.0.1 6443 -v
nc: connectx to 127.0.0.1 port 6443 (tcp) failed: Connection refused

Copy link

linux-foundation-easycla bot commented Jan 1, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: ksemele / name: Alexey (2700ea0)

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jan 1, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jan 1, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @ksemele!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 1, 2024
Copy link

netlify bot commented Jan 1, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 2700ea0
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6592ea6f6787b000082bf47a
😎 Deploy Preview https://deploy-preview-44600--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 1, 2024
@ksemele ksemele force-pushed the fix/install-kubeadm-explanations branch from ef0ac43 to 2700ea0 Compare January 1, 2024 16:38
@ksemele ksemele changed the title Added lint to netcat official repository; Added -v key to netcat comm… Added link to netcat official site and '-v' key to netcat command example Jan 1, 2024
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, also mention that netcat is useful but optional, inside the section headed

## {{% heading "prerequisites" %}}

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 056ba5282030ff3c4707de830dc710f5bdeb3407

Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!
Congrats on your first PR 🎉

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dipesh-rawat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0649afc into kubernetes:main Mar 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants