Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRA documentation for 1.31 #46816

Merged
merged 1 commit into from
Jul 29, 2024
Merged

DRA documentation for 1.31 #46816

merged 1 commit into from
Jul 29, 2024

Conversation

pohly
Copy link
Contributor

@pohly pohly commented Jun 14, 2024 •
edited
Loading

This corresponds to kubernetes/enhancements#4709 with API changes from kubernetes/kubernetes#125488.

It covers both DRA KEPs.

@k8s-ci-robot k8s-ci-robot added this to the 1.31 milestone Jun 14, 2024
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 14, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 14, 2024 •
edited
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 5b40c51
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/66968e6cd7b2470008bafee2

@k8s-ci-robot k8s-ci-robot requested a review from kbhawkey June 14, 2024 08:04
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jun 14, 2024
@k8s-ci-robot k8s-ci-robot requested a review from klueska June 14, 2024 08:04
@pohly pohly mentioned this pull request Jun 14, 2024
Open
18 tasks
@netlify Netlify
Copy link

netlify bot commented Jun 14, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 5b40c51
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66968e6c43bc62000830cfbf
😎 Deploy Preview https://deploy-preview-46816--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pohly pohly mentioned this pull request Jun 14, 2024
Closed
42 tasks
@hacktivist123
Copy link
Contributor

Hello @pohly 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday July 16th, 2024 18:00 PST. Thank you!

@Princesso
Copy link
Contributor

Hi @pohly, a gentle reminder that tomorrow is the deadline for having your Docs PR ready for review. Please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before tomorrow, Tuesday, July 16th, 2024 18:00 PST.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 16, 2024
@pohly pohly changed the title WIP: DRA documentation for 1.31 DRA documentation for 1.31 Jul 16, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 16, 2024
@pohly
DRA: update for 1.31
5b40c51 
The concepts are mostly the same as before. Support for parameters in a CRD was
removed in favor of storing selection and configuration parameters directly in
ResourceClaim and DeviceClass.
@Princesso
Copy link
Contributor

Princesso commented Jul 19, 2024 •
edited
Loading

/sig node

@hacktivist123
Copy link
Contributor

Hello @pohly 👋! I'm reaching out from the Docs team. Just checking in as we approach Docs Freeze on Tuesday, July 30th 18:00 PDT. This documentation appears to still be under review. To meet the Docs Freeze, this PR must have a technical review as well as lgtm and approve labels applied, without any unaddressed comments or concerns from SIG Docs. The status of this enhancement is marked as at risk for docs freeze. Thank you

@hacktivist123
Copy link
Contributor

/sig node

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Jul 25, 2024
@sftim
Copy link
Contributor

sftim commented Jul 26, 2024

If a review is needed @hacktivist123, the folks to ask are @kubernetes/sig-docs-en-reviews

@Princesso
Copy link
Contributor

Hello @pohly ,

v1.31 Doc Lead here. This PR has been marked as at risk for Doc Freeze.

The Doc Reviewers have given feedback on it, however, an update is yet to be made on it, based on feedback.

Please note that the Doc freeze deadline is tomorrow, and if the PR is not merged by tomorrow, you will need to file an exception or this enhancement will be removed from this release. Thank you!

@bart0sh
Copy link
Contributor

bart0sh commented Jul 29, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b0d2621895c56f52ecf7ae62db593240eef2f7c8

@pohly
Copy link
Contributor Author

pohly commented Jul 29, 2024

/assign @natalisucks

For approval (beware, doc freeze).

@reylejano
Copy link
Member

I verified DRA's enhancement status in the DRA kep.yaml and corresponding enhancement issue
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit a8f156b into kubernetes:dev-1.31 Jul 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

@klueska klueska Awaiting requested review from klueska

Assignees

@bart0sh bart0sh

@natalisucks natalisucks

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Node: code and documentation PRs
Archived in project
Milestone
1.31
Development

Successfully merging this pull request may close these issues.
8 participants
@pohly @hacktivist123 @Princesso @sftim @bart0sh @k8s-ci-robot @reylejano @natalisucks