-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Docsy 0.5.1 via NPM module (1.31 backport) #49031
Upgrade to Docsy 0.5.1 via NPM module (1.31 backport) #49031
Conversation
✅ Deploy Preview for k8s-v1-31 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/hold /area web-development |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Adapt the existing page to work with (near-)vanilla Docsy. This includes new localizable strings.
Put legacy and current styles in one place, and simplify CSS load.
Hmm. https://deploy-preview-49031--k8s-v1-31.netlify.app/community/ looks wrong and I cannot figure out why. /retitle [WIP] Upgrade to Docsy 0.5.1 via NPM module (1.31 backport) |
As I mentioned on Slack, the disappearing footer problem is solved if we remove the a) include |
465fe08
to
6c973ae
Compare
/retitle Upgrade to Docsy 0.5.1 via NPM module (1.31 backport) Should stay held until PR #48812 merges |
/hold cancel #48812 has merged |
I put a workaround in place for the minimum page height, and all looks good. |
The footer looks good in both my browsers now! 👍 However, the |
If we can save the fix to a follow-up PR, let's do that. |
Absolutely! I checked this issue for the currently rendered website and realised it's here already (unrelated to this upgrade). Thus, created another PR to fix it: #49364 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Nice that this fixes the missing footers in the Partners and Community pages, e.g.:
I'm assuming others have checked the containerized build and serve.
/cc @nate-double-u
Anything holding this back @sftim et all? |
This PR is waiting on reviewer capacity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming others have checked the containerized build and serve.
I've spun this up in a container and it looks good. (With the caveat that I still need to do the api-ref-generator dance - but that's not an issue with this PR)
/lgtm
LGTM label has been added. Git tree hash: 90b91396d61bc5cc7b578a502975ced73addd9ed
|
This is likely to throw up #49460 - and I'm OK with that (people rarely work on the release-1.31 branch with a local preview). |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chalin, reylejano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Based on PR #48812 by @chalin
Upgrade the v1.31 docs to use Docsy 0.5.1