Restore gate jobs #8388
Restore gate jobs #8388
Conversation
Most gate jobs have been disabled recently so we are risking introduce many defects when migrating to Hugo. This PR fixes the gate job to get it running again.
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit 6457c21 https://deploy-preview-8388--kubernetes-io-master-staging.netlify.com |
|
/assign @chenopis |
| @@ -42,7 +42,7 @@ type CanonicalTag struct { | |||
| // Checks that all glossary files (../_data/glossary/*) contain valid tags | |||
| // that are present in the canonical set. | |||
| func TestCanonicalTags(t *testing.T) { | |||
| canonicalTagsDir := "../_data/canonical-tags" | |||
| canonicalTagsDir := "../data/canonical-tags" | |||
There was a problem hiding this comment.
I'm seeing an error message in Travis:
glossary_test.go:73: Unable to read directory ../data/glossary: open ../data/glossary: no such file or directory
This is because we're no longer using YAML files to generate the glossary so that data directory has been removed. Consequently, this file can be deleted.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chenopis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Most gate jobs have been disabled recently so we are risking introduce
many defects when migrating to Hugo. This PR fixes the gate job to get
it running again.