Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark ExpandPersistentVolumes feature to beta #8778

Merged
merged 2 commits into from
Jun 2, 2018
Merged

Mark ExpandPersistentVolumes feature to beta #8778

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
204afbd
Update version selector for 1.11
May 15, 2018
0c9a403
Mark ExpandPersistentVolumes Beta
tengqm May 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,8 @@ githubbranch = "v1.11.0"
docsbranch = "release-1.11"
url = "https://kubernetes.io"

[[params.versions]]
fullversion = "v1.10.3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you change this on purpose? If not, can you revert? If so, can you let me know why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this was changed on purpose. Problem found when I was rebasing my local release-1.11 branch to the upstream release-1.11 branch. The problem is not evident when rendered by github.

Before change:

 [[params.versions]]
 fullversion = "v1.11.0"
 version = "v1.11"
 githubbranch = "v1.11.0"
 docsbranch = "release-1.11"
 url = "https://kubernetes.io"

 version = "v1.10"
 githubbranch = "v1.10.3"
 docsbranch = "release-1.10"
 url = "https://kubernetes.io"

After change:

 [[params.versions]]
 fullversion = "v1.11.0"
 version = "v1.11"
 githubbranch = "v1.11.0"
 docsbranch = "release-1.11"
 url = "https://kubernetes.io"

 [[params.versions]]
 fullversion = "v1.10.3"
 version = "v1.10"
 githubbranch = "v1.10.3"
 docsbranch = "release-1.10"
 url = "https://kubernetes.io"

The difference is clearer, right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bradamant3 @zacharysarah was this a missed step in the 1.10 release? Is this a new requirement with Hugo? I'm shaky on the config.toml syntax.

version = "v1.10"
githubbranch = "v1.10.3"
docsbranch = "release-1.10"
Expand Down
3 changes: 2 additions & 1 deletion content/en/docs/reference/command-line-tools-reference/feature-gates.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,8 @@ different Kubernetes components.
| `DynamicVolumeProvisioning` | `true` | Alpha | 1.3 | 1.7 |
| `DynamicVolumeProvisioning` | `true` | GA | 1.8 | |
| `EnableEquivalenceClassCache` | `false` | Alpha | 1.8 | |
| `ExpandPersistentVolumes` | `false` | Alpha | 1.8 | 1.8 |
| `ExpandPersistentVolumes` | `false` | Alpha | 1.8 | 1.10 |
| `ExpandPersistentVolumes` | `true` | Beta | 1.11 | |
| `ExperimentalCriticalPodAnnotation` | `false` | Alpha | 1.5 | |
| `ExperimentalHostUserNamespaceDefaulting` | `false` | Beta | 1.5 | |
| `GCERegionalPersistentDisk` | `true` | Beta | 1.10 | |
Expand Down