Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some issues with ToC #8797

Merged
merged 2 commits into from
Jun 4, 2018
Merged

Fix some issues with ToC #8797

merged 2 commits into from
Jun 4, 2018

Conversation

bep
Copy link
Contributor

@bep bep commented May 29, 2018

bep added 2 commits May 29, 2018 10:14
@bep
Allow HTML in ToC
eae4b1a 
Fixes kubernetes#4793
@bep
Extract ToC id from the header
46b6991 
This is needed when the id is set explicitly in markdown.
@k8s-ci-robot
Copy link
Contributor

@bep: GitHub didn't allow me to request PR reviews from the following users: lovejoy.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

See gohugoio/hugo#4793

/cc @lovejoy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 29, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 46b6991

https://deploy-preview-8797--kubernetes-io-master-staging.netlify.com

@bep
Copy link
Contributor Author

bep commented May 29, 2018

See https://deploy-preview-8797--kubernetes-io-master-staging.netlify.com/docs/setup/independent/high-availability/ for an example.

/assign @MistyHacks

@lovejoy
Copy link
Contributor

lovejoy commented May 29, 2018

cool

@mdlinville
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 4, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mistyhacks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2018
@k8s-ci-robot k8s-ci-robot merged commit a7d2dfc into kubernetes:master Jun 4, 2018
@mdlinville mdlinville mentioned this pull request Jun 5, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mdlinville mdlinville

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bep @k8s-ci-robot @k8sio-netlify-preview-bot @lovejoy @mdlinville