Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inconsistencies in Flexvolume docs #9706

Merged
merged 2 commits into from
Aug 22, 2018
Merged

Fix inconsistencies in Flexvolume docs #9706

merged 2 commits into from
Aug 22, 2018

Conversation

mdlinville
Copy link
Contributor

Relates to #9666
/assign @tfogo

@k8s-ci-robot
Copy link
Contributor

@MistyHacks: GitHub didn't allow me to assign the following users: tfogo.

Note that only kubernetes members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

Relates to #9666
/assign @tfogo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 1, 2018
@k8s-ci-robot k8s-ci-robot requested review from jsafrane and pweil- August 1, 2018 18:18
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Aug 1, 2018 •
edited
Loading

Deploy preview for kubernetes-io-master-staging ready!

Built with commit eabc8f6

https://deploy-preview-9706--kubernetes-io-master-staging.netlify.com

@mdlinville
Copy link
Contributor Author

/cc @tfogo

@k8s-ci-robot
Copy link
Contributor

@MistyHacks: GitHub didn't allow me to request PR reviews from the following users: tfogo.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @tfogo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

php-coder
php-coder approved these changes Aug 4, 2018
View reviewed changes
Copy link
Contributor

@php-coder php-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for PSP chapter.

@tfogo
Copy link
Contributor

tfogo commented Aug 7, 2018

I think the use of backticks is also inconsistent. I think the code-formatted names should only be plugin names as they are referred to in yaml. So "CSI" and "Flexvolume" are the concepts, csi and flexVolume are the plugins. Having CSI or Flexvolume formatted doesn't make sense to me.

This is how the StorageOS plugin section works, for example.

(btw, sorry for the late response - have been on vacation)

@chenopis chenopis self-assigned this Aug 21, 2018
@chenopis
Copy link
Contributor

chenopis commented Aug 21, 2018 •
edited
Loading

@MistyHacks Looks like there's a merge conflict. Otherwise...
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chenopis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2018
@chenopis chenopis added this to the WtD Cincy milestone Aug 21, 2018
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 22, 2018
@mdlinville
Copy link
Contributor Author

/lgtm

@k8s-ci-robot
Copy link
Contributor

@MistyHacks: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mdlinville
Copy link
Contributor Author

Merging manually.

@mdlinville mdlinville merged commit c3b86b2 into kubernetes:master Aug 22, 2018
@mdlinville mdlinville deleted the flexvolume branch August 22, 2018 23:40
rosti pushed a commit to rosti/website that referenced this pull request Aug 23, 2018
@rosti
Fix inconsistencies in Flexvolume docs (kubernetes#9706)
39622fd 
* Fix inconsistencies in Flexvolume docs

* remove code highlighting for Flexvolume and CSI
krmayankk pushed a commit to krmayankk/kubernetes.github.io that referenced this pull request Aug 28, 2018
Fix inconsistencies in Flexvolume docs (kubernetes#9706)
56d0d84 
* Fix inconsistencies in Flexvolume docs

* remove code highlighting for Flexvolume and CSI
krmayankk pushed a commit to krmayankk/kubernetes.github.io that referenced this pull request Aug 28, 2018
Fix inconsistencies in Flexvolume docs (kubernetes#9706)
21c69ad 
* Fix inconsistencies in Flexvolume docs

* remove code highlighting for Flexvolume and CSI
@tfogo tfogo mentioned this pull request Aug 30, 2018
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@php-coder php-coder php-coder approved these changes

@jsafrane jsafrane Awaiting requested review from jsafrane

@pweil- pweil- Awaiting requested review from pweil-

Assignees

@chenopis chenopis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
WtD Cincy
Development

Successfully merging this pull request may close these issues.
6 participants
@mdlinville @k8s-ci-robot @k8sio-netlify-preview-bot @tfogo @chenopis @php-coder