Adjust kubectl docs to reflect plugin approach #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mszostok
force-pushed
the
kubectl-plugin
branch
from
1ff2b84 to
3735625
Compare
mszostok
force-pushed
the
kubectl-plugin
branch
from
3735625 to
86414aa
Compare
pkosiec
reviewed
Feb 16, 2023
There was a problem hiding this comment.
Looks good, a few comments. Also please see the review kubeshop/botkube#982 🙂
| The `kubectl` executor allows you to run the `kubectl` command directly in the chat window of each communication platform. | ||
| The Botkube Kubectl executor plugin allows you to run the `kubectl` command directly in the chat window of each communication platform. | ||
|
|
||
| The Kubectl plugin is hosted by the official Botkube plugin repository. To enable the Helm plugin, make sure that the `botkube` repository is defined under `plugins` in the [values.yaml](https://github.com/kubeshop/botkube/blob/main/helm/botkube/values.yaml) file. |
There was a problem hiding this comment.
I know it's the same as the Helm plugin, but are you sure it should be by instead of in? If yes, please ignore this comment.
Suggested change
| The Kubectl plugin is hosted by the official Botkube plugin repository. To enable the Helm plugin, make sure that the `botkube` repository is defined under `plugins` in the [values.yaml](https://github.com/kubeshop/botkube/blob/main/helm/botkube/values.yaml) file. | |
| The Kubectl plugin is hosted in the official Botkube plugin repository. To enable the Helm plugin, make sure that the `botkube` repository is defined under `plugins` in the [values.yaml](https://github.com/kubeshop/botkube/blob/main/helm/botkube/values.yaml) file. |
pkosiec
approved these changes
Feb 17, 2023
mszostok
force-pushed
the
kubectl-plugin
branch
from
dfa3713 to
b768f3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Testing
Preview URLs:
Related issue(s)