Reduce number of prod tests, add missing error assertions (#1411)

kubeshop · Mar 11, 2024 · add04f0 · add04f0
1 parent 3f92298
commit add04f0
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 10 deletions.
diff --git a/.github/workflows/branch-build.yml b/.github/workflows/branch-build.yml
@@ -268,14 +268,6 @@ jobs:
         run: |
           KUBECONFIG=$(k3d kubeconfig write cli-migration-e2e-cluster) make test-cli-migration-e2e
 
-      - name: Upload artifacts
-        uses: actions/upload-artifact@v4
-        if: ${{ always() }}
-        with:
-          name: screenshots_dump_${{github.sha}}
-          path: ${{ runner.temp }}/screenshots
-          retention-days: 5
-
       - name: Dump cluster state
         if: ${{ failure() }}
         uses: ./.github/actions/dump-cluster

diff --git a/.github/workflows/prod-e2e-test.yml b/.github/workflows/prod-e2e-test.yml
@@ -3,7 +3,7 @@ name: Botkube Cloud Prod E2E test
 on:
   workflow_dispatch:
   schedule:
-    - cron: "0 */1 * * *" # Every 1 hour
+    - cron: "0 */4 * * *" # Every 4 hours
 
 env:
   HELM_VERSION: v3.9.0

diff --git a/test/cloud-slack-dev-e2e/cloud_slack_dev_e2e_test.go b/test/cloud-slack-dev-e2e/cloud_slack_dev_e2e_test.go
@@ -278,7 +278,7 @@ func TestCloudSlackE2E(t *testing.T) {
 		_, err := shortBkTimeoutPage.ElementR(".ant-layout-content p", "All Botkube installations managed by Botkube Cloud.")
 		if err != nil {
 			t.Logf("Failed to detect homepage with other instances created: %v", err)
-			// Case 2:
+			// Fallback to Case 2: No other instances created
 			t.Logf("Checking if the homepage is in the 'no instances' state...")
 			_, err := botkubePage.ElementR(".ant-layout-content h2", "Create your Botkube instance!")
 			assert.NoError(t, err)
@@ -363,6 +363,7 @@ func TestCloudSlackE2E(t *testing.T) {
 			return strings.Contains(msg, fmt.Sprintf("Botkube instance %q is now active.", deployment.Name)), 0, ""
 		}
 		err = tester.WaitForMessagePosted(tester.BotUserID(), channel.ID(), 3, assertionFn)
+		require.NoError(t, err)
 
 		cmdHeader := func(command string) string {
 			return fmt.Sprintf("`%s` on `%s`", command, deployment.Name)
@@ -489,6 +490,7 @@ func TestCloudSlackE2E(t *testing.T) {
 				}
 				return true, 0, ""
 			})
+			require.NoError(t, err)
 
 			t.Log("Verifying disabled notification on Cloud...")
 			deploy := gqlCli.MustGetDeployment(t, graphql.ID(deployment.ID))