Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Microsoft Teams integration tests fail on plaintext messages #1423

Closed
pkosiec opened this issue Mar 26, 2024 · 0 comments · Fixed by #1429
Closed

Microsoft Teams integration tests fail on plaintext messages #1423

pkosiec opened this issue Mar 26, 2024 · 0 comments · Fixed by #1429
Assignees
@mszostok
Labels
bug Something isn't working ci Related to CI pipelines
Milestone
v1.10.0

Comments

@pkosiec
Copy link
Collaborator

pkosiec commented Mar 26, 2024

Description

Currently Teams integration tests fail 100% of times because of different plaintext message formatting

Draft PR: #1419
Last run: https://github.com/kubeshop/botkube/actions/runs/8419792510/job/23053256939 (look for "Error Trace" text occurrences).

The draft PR fixed the welcome message assertion but there are 4 other places where we need to fix it.

Possible issues in the renderer itself

  • empty response seems to be incomplete (missing cricket sounds)
>> Plaintext EXP: `echo help` on `test-first-4d704814-a3fb-497b-b652-a1349ac02a7e`
.... empty response _*<cricket sounds>*_ 🦗 🦗 🦗

>> Plaintext GOT: `echo help` on `test-first-4d704814-a3fb-497b-b652-a1349ac02a7e`
.... empty response  🦗 🦗 🦗
  • it seems that the plaintext responses are inconsistent with Slack 🤔 maybe I'm wrong though
@pkosiec pkosiec added bug Something isn't working ci Related to CI pipelines labels Mar 26, 2024
@pkosiec pkosiec added this to the v1.10.0 milestone Mar 26, 2024
@pkosiec pkosiec added this to Botkube Mar 26, 2024
@mszostok mszostok self-assigned this Mar 26, 2024
@mszostok mszostok moved this to In Progress in Botkube Mar 26, 2024
@mszostok mszostok mentioned this issue Apr 8, 2024
Merged
@mszostok mszostok moved this from In Progress to To Review in Botkube Apr 8, 2024
@github-project-automation github-project-automation bot moved this from To Review to To Release (Cloud only) in Botkube Apr 9, 2024
@pkosiec pkosiec moved this from To Release (Cloud only) to Done in Botkube Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mszostok mszostok

Labels
bug Something isn't working ci Related to CI pipelines
Projects
Botkube
Status: Done
Milestone
v1.10.0
Development

Successfully merging a pull request may close this issue.

Fix Teams integration tests assertions mszostok/botkube
2 participants
@pkosiec @mszostok