-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix MS Teams integration tests after renderer update #1419
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkosiec
added
ci
Related to CI pipelines
other
Internal, no user-facing changes.
labels
Mar 19, 2024
pkosiec
force-pushed
the
fix-teams-int-tests
branch
from
March 19, 2024 16:27
bcca086
to
d06914c
Compare
pkosiec
force-pushed
the
fix-teams-int-tests
branch
from
March 25, 2024 09:37
3cbbb27
to
bbb466f
Compare
pkosiec
commented
Mar 26, 2024
Comment on lines
+321
to
+323
if botDriver.Type() == commplatform.TeamsBot { | ||
expectedWelcomeMsg = strings.Replace(expectedWelcomeMsg, ":crossed_swords:", "⚔️", 1) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably not needed anymore as s.AssertEqual
underneath already replaces the emoji 👍
Fix will be handled in #1429 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request: