You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The configuration changes made via @BotKube commands are not persisted. As a result, when the Pod is restarted, we lost all changes.
In K8s world, the Pod restarts are a normal thing, and we should be resistant to it.
Acceptance Criteria
Research what's the best option here from UX and maintenance point of view. [1MD]
@Botkube notifier stop/start changes are persisted
@BotKube filters disable/enable changes are persisted
Persist source bindings
They override bindings from the configuration
Support configuration for notifier, filter, source bindings during Helm install/upgrade and @BotKube commands
We don't add new features besides the persistency. For example, the @BotKube filters disable/enable command still can work globally.
E2E Tests
consider: ensure @Botkube notify stop/start doesn't restart the pod/
kill the pod and see whether notifier config / filter config is saved
define the filters configuration under filters.kubernetes in values.yaml
Steps to reproduce
Install BotKube inside cluster
Run @BotKube notifier stop
Kill the pod, e.g. kubectl delete po -l app=botkube
See that you get a new message on channel:
...and now my watch begins for cluster 'gke' ! ⚔️
Notes
If we use the existing one with global configuration, the Pod will be restarted, which is not needed because of that we can store the data in dedicated ConfigMap.
The text was updated successfully, but these errors were encountered:
pkosiec
changed the title
The configuration changes made via @BotKube commands are not persisted
Persist configuration changes made via @BotKube notify/filter commands
Aug 29, 2022
pkosiec
changed the title
Persist configuration changes made via @BotKube notify/filter commands
Consume BotKube configuration from values.yaml and commands
Sep 2, 2022
Description
The configuration changes made via
@BotKube
commands are not persisted. As a result, when the Pod is restarted, we lost all changes.In K8s world, the Pod restarts are a normal thing, and we should be resistant to it.
Acceptance Criteria
@Botkube notifier stop/start
changes are persisted@BotKube filters disable/enable
changes are persisted@BotKube
commands@BotKube filters disable/enable
command still can work globally.@Botkube notify stop/start
doesn't restart the pod/define the filters configuration under
filters.kubernetes
invalues.yaml
Steps to reproduce
@BotKube notifier stop
kubectl delete po -l app=botkube
Notes
If we use the existing one with global configuration, the Pod will be restarted, which is not needed because of that we can store the data in dedicated ConfigMap.
The text was updated successfully, but these errors were encountered: