Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consume BotKube configuration from values.yaml and commands #704

Closed
Tracked by #711
mszostok opened this issue Aug 26, 2022 · 0 comments · Fixed by kubeshop/botkube-docs#151
Closed
Tracked by #711

Consume BotKube configuration from values.yaml and commands #704

mszostok opened this issue Aug 26, 2022 · 0 comments · Fixed by kubeshop/botkube-docs#151
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@mszostok
Copy link
Collaborator

mszostok commented Aug 26, 2022

Description

The configuration changes made via @BotKube commands are not persisted. As a result, when the Pod is restarted, we lost all changes.

In K8s world, the Pod restarts are a normal thing, and we should be resistant to it.

Acceptance Criteria

  1. Research what's the best option here from UX and maintenance point of view. [1MD]
  2. @Botkube notifier stop/start changes are persisted
  3. @BotKube filters disable/enable changes are persisted
  4. Persist source bindings
    • They override bindings from the configuration
  5. Support configuration for notifier, filter, source bindings during Helm install/upgrade and @BotKube commands
  6. We don't add new features besides the persistency. For example, the @BotKube filters disable/enable command still can work globally.
  7. E2E Tests
  • consider: ensure @Botkube notify stop/start doesn't restart the pod/
  • kill the pod and see whether notifier config / filter config is saved

define the filters configuration under filters.kubernetes in values.yaml

Steps to reproduce

  1. Install BotKube inside cluster
  2. Run @BotKube notifier stop
  3. Kill the pod, e.g. kubectl delete po -l app=botkube
  4. See that you get a new message on channel:

    ...and now my watch begins for cluster 'gke' ! ⚔️

Notes

If we use the existing one with global configuration, the Pod will be restarted, which is not needed because of that we can store the data in dedicated ConfigMap.

@mszostok mszostok added the bug Something isn't working label Aug 26, 2022
@brampling brampling added the enhancement New feature or request label Aug 26, 2022
@brampling brampling moved this to Todo in Botkube Aug 26, 2022
@brampling brampling added this to the v0.14.0 milestone Aug 26, 2022
@madebyrogal madebyrogal self-assigned this Aug 29, 2022
@pkosiec pkosiec removed the bug Something isn't working label Aug 29, 2022
@pkosiec pkosiec changed the title The configuration changes made via @BotKube commands are not persisted Persist configuration changes made via @BotKube notify/filter commands Aug 29, 2022
This was referenced Aug 29, 2022
@pkosiec pkosiec changed the title Persist configuration changes made via @BotKube notify/filter commands Consume BotKube configuration from values.yaml and commands Sep 2, 2022
@pkosiec pkosiec self-assigned this Sep 2, 2022
@pkosiec pkosiec moved this from Todo to In Progress in Botkube Sep 5, 2022
@pkosiec pkosiec moved this from In Progress to To Review in Botkube Sep 7, 2022
@pkosiec pkosiec moved this from To Review to In Progress in Botkube Sep 21, 2022
@pkosiec pkosiec moved this from In Progress to To Review in Botkube Sep 27, 2022
@pkosiec pkosiec moved this from To Review to In Progress in Botkube Sep 27, 2022
@pkosiec pkosiec moved this from In Progress to To Review in Botkube Sep 29, 2022
Repository owner moved this from To Review to Done in Botkube Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants