Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate persistent configuration for BotKube commands #724

Merged
merged 2 commits into from
Sep 8, 2022
Merged

Investigate persistent configuration for BotKube commands #724

merged 2 commits into from
Sep 8, 2022

Conversation

pkosiec
Copy link
Collaborator

@pkosiec pkosiec commented Sep 7, 2022 •
edited
Loading

Description

Changes proposed in this pull request:

  • Investigate persistent configuration for BotKube commands

To do

  • Discuss it with the team
  • Write down the agreements (in the "Consequences" section).

Related issue(s)

See #704

@pkosiec pkosiec added enhancement New feature or request documentation Documetation is missing or incorrect labels Sep 7, 2022
@pkosiec pkosiec added this to the v0.15.0 milestone Sep 7, 2022
@pkosiec pkosiec force-pushed the persistent-cfg-from-cmds branch from ff24b77 to fef9ca8 Compare September 7, 2022 10:38
@pkosiec pkosiec marked this pull request as ready for review September 7, 2022 10:45
@pkosiec pkosiec requested a review from a team September 7, 2022 10:45
@pkosiec pkosiec requested a review from PrasadG193 as a code owner September 7, 2022 10:45
@pkosiec pkosiec requested a review from ezodude September 7, 2022 10:45
mszostok
mszostok approved these changes Sep 8, 2022
View reviewed changes
Copy link
Collaborator

@mszostok mszostok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with the 3rd option 👍

docs/investigation/configuration/2022-09-07-persistent-cfg-from-commands.md Outdated Show resolved Hide resolved
@ezodude ezodude self-requested a review September 8, 2022 09:38
@pkosiec pkosiec merged commit d90920c into kubeshop:main Sep 8, 2022
@pkosiec pkosiec deleted the persistent-cfg-from-cmds branch September 8, 2022 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mszostok mszostok mszostok approved these changes

@huseyinbabal huseyinbabal huseyinbabal approved these changes

@ezodude ezodude ezodude approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees

@ezodude ezodude

@huseyinbabal huseyinbabal

@mszostok mszostok

Labels
documentation Documetation is missing or incorrect enhancement New feature or request
Projects
None yet
Milestone
v0.15.0
Development

Successfully merging this pull request may close these issues.
4 participants
@pkosiec @ezodude @huseyinbabal @mszostok