Reload Botkube on remote config change

[pkosiec]

Description

Changes proposed in this pull request:

• Reload Botkube on remote config change

Limitations

As the TODO comment states, right now Botkube will reload on every config change:

	// TODO: check if notifications are enabled and if so:
	//  - update notifications for a given channel (this needs a global state)
	//  - send message to a given channel (this needs a rework for the notifier executor)
	//    - updating notifications should happen after ConfigMap update, not before
	//    - same for remote config reloader
	//  - do not restart the app

This is something to address in future.

Follow-ups

• Rework ConfigMap-based Config Watcher #1011
• Avoid reloading Botkube when notification preferences change via remote config #1012

[mszostok]

one of you will end-up with conflicts 😄
#1007

[mszostok]

Tested e2e, works great 🚀

[joselcvarela]

Hey guys,
Nice job with this bot, really helpful 👍

I just saw the {{- if .Values.config.provider.endpoint }} was removed.
Any particular reason for it?
This is an old commit but this change is still on HEAD.

Thank you.

[mszostok]

Hi @joselcvarela 👋

I'm glad you like Botkube! 🚀

Regarding this change, while we could maintain it, we're currently using the default value here:https://github.com/kubeshop/botkube/blob/main/helm/botkube/values.yaml#L1228.

As long as you don't remove or override it, it should render properly.
However, this endpoint will only be utilized if the CONFIG_PROVIDER_IDENTIFIER is set; otherwise, it will be ignored, and the local configuration will be used. In such cases, no external calls are executed. You can find the code responsible for this here.

Did you encounter any problems with it?

[joselcvarela]

Thank you for your response.
No, I haven't seen any issue so far.
I was just looking through the values passed to templates, and this part was intriguing me 👍
Keep on with the good job 🙌