Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to configure liveness and readiness probes #1056

Merged
merged 4 commits into from
May 11, 2023

Conversation

huseyinbabal
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Added configurable liveness+readiness probe

Testing

helm upgrade --install botkube \
  --version v1.0.0 \
  --namespace botkube \
  --create-namespace \
  --wait \
  --set config.provider.endpoint=https://api-dev.botkube.io/graphql \
  --set config.provider.identifier=... \
  --set config.provider.apiKey=... \
  ./helm/botkube

And check liveness + readiness probe, they should have default values as described in values.yaml. You can also customize it as shown below

deployment:
  livenessProbe:
    periodSeconds: 120
  readinessProbe:
    periodSeconds: 120
helm upgrade --install botkube \
  --version v1.0.0 \
  --namespace botkube \
  --create-namespace \
  --wait \
  --set config.provider.endpoint=https://api-dev.botkube.io/graphql \
  --set config.provider.identifier=... \
  --set config.provider.apiKey=... \
  ./helm/botkube -f /tmp/bk-cfg.yaml

Related issue(s)

Fixes #1055

@huseyinbabal huseyinbabal requested a review from a team May 11, 2023 08:50
@huseyinbabal huseyinbabal requested a review from PrasadG193 as a code owner May 11, 2023 08:50
@huseyinbabal huseyinbabal requested a review from pkosiec May 11, 2023 08:50
Copy link
Collaborator

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just please apply suggestion to improve the comment 🙂
And let's tweak the default values a bit. Thanks!

helm/botkube/values.yaml Outdated Show resolved Hide resolved
@huseyinbabal huseyinbabal merged commit fff602f into kubeshop:main May 11, 2023
@huseyinbabal huseyinbabal deleted the configurable-probes branch May 11, 2023 10:16
pkosiec pushed a commit to pkosiec/botkube that referenced this pull request May 11, 2023
pkosiec pushed a commit that referenced this pull request May 11, 2023
(cherry picked from commit fff602f)
@pkosiec pkosiec added the enhancement New feature or request label May 12, 2023
@pkosiec pkosiec changed the title configurable probes added Add ability to configure liveness and readiness probes May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configurable Probes
2 participants