Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use kubeconfig for gh plugin #1062

Merged
merged 2 commits into from
May 12, 2023
Merged

use kubeconfig for gh plugin #1062

merged 2 commits into from
May 12, 2023

Conversation

huseyinbabal
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Now GH plugin uses kubeconfig provided by botkube core.

Testing

  • Build plugins
  • Run plugin serve
  • Use gh plugin and run botkube

Related issue(s)

Relates #1021

@huseyinbabal huseyinbabal requested a review from a team May 11, 2023 17:20
@huseyinbabal huseyinbabal requested a review from PrasadG193 as a code owner May 11, 2023 17:20
@huseyinbabal huseyinbabal requested a review from pkosiec May 11, 2023 17:20
@huseyinbabal huseyinbabal mentioned this pull request May 11, 2023
Closed
@pkosiec pkosiec self-assigned this May 12, 2023
@pkosiec pkosiec added the bug Something isn't working label May 12, 2023
pkosiec
pkosiec approved these changes May 12, 2023
View reviewed changes
Copy link
Collaborator

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works flawlessly 🚀

@huseyinbabal huseyinbabal merged commit 788b4b1 into kubeshop:main May 12, 2023
@huseyinbabal huseyinbabal deleted the github-executor-kubeconfig branch May 12, 2023 09:36
pkosiec pushed a commit to pkosiec/botkube that referenced this pull request May 12, 2023
@huseyinbabal @pkosiec
use kubeconfig for gh plugin (kubeshop#1062)
ae57a34 
(cherry picked from commit 788b4b1)
pkosiec pushed a commit that referenced this pull request May 12, 2023
@huseyinbabal @pkosiec
use kubeconfig for gh plugin (#1062)
504576c 
(cherry picked from commit 788b4b1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkosiec pkosiec pkosiec approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees

@pkosiec pkosiec

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huseyinbabal @pkosiec