Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugin repo for release #1069

Merged
merged 2 commits into from
May 22, 2023

Conversation

pkosiec
Copy link
Collaborator

@pkosiec pkosiec commented May 22, 2023

Description

Changes proposed in this pull request:

  • Update plugin repo for release

Testing

Run the changes in isolation:

docker run --rm -it alpine sh
wget https://raw.githubusercontent.com/pkosiec/botkube/update-plugin-repo-for-release/helm/botkube/values.yaml
cat values.yaml

# export env vars
export LATEST_PLUGIN_INDEX_URL="https://storage.googleapis.com/botkube-plugins-latest/plugins-index.yaml"
export HELM_FOLDER="."
export NEXT_VERSION="v1.0.1"

# run slightly modified line (we replaced `${{ inputs.next-version }}` with `${NEXT_VERSION}`
find ${HELM_FOLDER} -name "*.yaml" -exec sed -i "s~${LATEST_PLUGIN_INDEX_URL}~https://github.com/kubeshop/botkube/releases/download/${NEXT_VERSION}/plugins-index.yaml~g" {} +

cat values.yaml

Related issue(s)

Resolves #1032

@pkosiec pkosiec added bug Something isn't working ci Related to CI pipelines labels May 22, 2023
@pkosiec pkosiec marked this pull request as ready for review May 22, 2023 11:44
@pkosiec pkosiec requested a review from a team May 22, 2023 11:44
@pkosiec pkosiec requested a review from PrasadG193 as a code owner May 22, 2023 11:44
@pkosiec pkosiec requested a review from josefkarasek May 22, 2023 11:44
Copy link

@josefkarasek josefkarasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@pkosiec pkosiec enabled auto-merge (squash) May 22, 2023 11:56
@pkosiec pkosiec merged commit 24e92eb into kubeshop:main May 22, 2023
@pkosiec pkosiec deleted the update-plugin-repo-for-release branch May 22, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci Related to CI pipelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle plugin repo url during release
2 participants