Calculate and check sha256 of plugins #1072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josefkarasek
force-pushed
the
download-plugins
branch
from
1679ecb to
4d3f134
Compare
josefkarasek
force-pushed
the
download-plugins
branch
from
1a49a7b to
04bcdee
Compare
mszostok
approved these changes
May 25, 2023
test/fake/plugin_server.go
Outdated
| @@ -35,14 +35,11 @@ func NewPluginServer(cfg PluginConfig) (string, func() error) { | |||
|
|
|||
| basePath := fmt.Sprintf("%s:%d", cfg.Server.Host, cfg.Server.Port) | |||
| builder := plugin.NewIndexBuilder(loggerx.NewNoop()) | |||
|
|
|||
| idx, err := builder.Build(cfg.BinariesDirectory, basePath+"/static", ".*") | |||
There was a problem hiding this comment.
I put that inside the handler as I wanted to rebuild it each time botkube calls the endpoint. I'm using:
env PLUGIN_SERVER_HOST=http://host.k3d.internal go run test/helpers/plugin_server.go
as a long living process. So I don't need to restart that if I rebuild the binary, as it will fail on checksum. Can we revert that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
.downloadingfor plugins while they're being downloadedTesting
Rebuild your plugins
make build-plugins-singleand host them locallyPLUGIN_SERVER_HOST=http://localhost go run test/helpers/plugin_server.goIn another terminal check for plugin cache dir structure. While Botkube download plugins, you should see temp dir
.downloading. This dir should disappear when plugin download succeeds.Related issue(s)
#1027