Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ServiceAccount token path in Config Watcher #1096

Merged
merged 2 commits into from
Jun 16, 2023
Merged

Fix ServiceAccount token path in Config Watcher #1096

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67ed18c
in cluster config fixed for cfg watcher
huseyinbabal Jun 16, 2023
4815377
process chart
huseyinbabal Jun 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion helm/botkube/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ Controller for the Botkube Slack app which helps you monitor your Kubernetes clu
| [configWatcher.initialSyncTimeout](./values.yaml#L960) | int | `0` | Timeout for the initial Config Watcher sync. If set to 0, waiting for Config Watcher sync will be skipped. In a result, configuration changes may not reload Botkube app during the first few seconds after Botkube startup. |
| [configWatcher.image.registry](./values.yaml#L963) | string | `"ghcr.io"` | Config watcher image registry. |
| [configWatcher.image.repository](./values.yaml#L965) | string | `"kubeshop/k8s-sidecar"` | Config watcher image repository. |
| [configWatcher.image.tag](./values.yaml#L967) | string | `"ignore-initial-events"` | Config watcher image tag. |
| [configWatcher.image.tag](./values.yaml#L967) | string | `"in-cluster-config"` | Config watcher image tag. |
| [configWatcher.image.pullPolicy](./values.yaml#L969) | string | `"IfNotPresent"` | Config watcher image pull policy. |
| [plugins](./values.yaml#L972) | object | `{"cacheDir":"/tmp","repositories":{"botkube":{"url":"https://storage.googleapis.com/botkube-plugins-latest/plugins-index.yaml"}}}` | Configuration for Botkube executors and sources plugins. |
| [plugins.cacheDir](./values.yaml#L974) | string | `"/tmp"` | Directory, where downloaded plugins are cached. |
Expand Down
5 changes: 5 additions & 0 deletions helm/botkube/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,9 +165,14 @@ spec:
value: "POST"
- name: IGNORE_ALREADY_PROCESSED
value: "true"
- name: BOTKUBE_SETTINGS_SA__CREDENTIALS__PATH__PREFIX
value: /var/run/{{ $uuid }}/secrets/kubernetes.io/serviceaccount/{{ $uuid }}
volumeMounts:
- name: cfg-watcher-tmp
mountPath: {{ .Values.configWatcher.tmpDir }}
- name: {{ $uuid }}
mountPath: /var/run/{{ $uuid }}/secrets/kubernetes.io/serviceaccount
readOnly: true
{{- end }}
volumes:
- name: cache-volume
Expand Down
2 changes: 1 addition & 1 deletion helm/botkube/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -964,7 +964,7 @@ configWatcher:
# -- Config watcher image repository.
repository: kubeshop/k8s-sidecar # kiwigrid/k8s-sidecar:1.19.5 - see https://github.com/kubeshop/k8s-sidecar/pull/1
# -- Config watcher image tag.
tag: ignore-initial-events
tag: in-cluster-config
# -- Config watcher image pull policy.
pullPolicy: IfNotPresent

Expand Down