Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward action output to sinks #1341

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Forward action output to sinks #1341

merged 1 commit into from
Jan 10, 2024

Conversation

mszostok
Copy link
Collaborator

@mszostok mszostok commented Dec 22, 2023 •
edited
Loading

Description

Changes proposed in this pull request:

  • Forward action output to sinks

Testing

You can try this tutorial: https://docs.szostok.io/botkube-plugins/sources/incoming-http

@mszostok mszostok added the bug Something isn't working label Dec 22, 2023
@mszostok mszostok requested a review from pkosiec December 22, 2023 22:39
@mszostok mszostok marked this pull request as ready for review December 22, 2023 22:39
@mszostok mszostok requested a review from PrasadG193 as a code owner December 22, 2023 22:39
@mszostok mszostok requested a review from a team December 22, 2023 22:39
@pkosiec pkosiec self-assigned this Dec 27, 2023
pkosiec
pkosiec approved these changes Dec 27, 2023
View reviewed changes
Copy link
Collaborator

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well 👍

internal/source/dispatcher.go
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently we don't display actions as a part of sinks on Cloud UI. Please create a separate issue for that, as I don't think it will be trivial to address right now (Why? Actions require also executors, which are hidden as part of sinks; maybe it could be introduced as a part of actions UI overhaul)

internal/source/dispatcher.go
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add json struct tags for the api.Message? Right now I can see props Header, Description etc., and it would be great to have them properly capitalized.

image

BTW AFAIK K8s source event also lacks the proper capitalization for the struct fields.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussed f2f, this will introduce a breaking change between agents and cloud, meaning that we will need to have a conditional unmarshaling based on agent version. For now, we skip fixing it.

@pkosiec pkosiec added enhancement New feature or request and removed bug Something isn't working labels Dec 27, 2023
@mszostok mszostok force-pushed the forward-action-to-sinks branch from fb05b41 to 6eedab3 Compare January 10, 2024 10:10
@mszostok mszostok enabled auto-merge (squash) January 10, 2024 10:14
@mszostok mszostok merged commit 4cbaf8d into kubeshop:main Jan 10, 2024
15 checks passed
@mszostok mszostok deleted the forward-action-to-sinks branch January 10, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkosiec pkosiec pkosiec approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees

@pkosiec pkosiec

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mszostok @pkosiec