Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix integration and E2E tests after Cloud Dev update #1435

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Fix integration and E2E tests after Cloud Dev update #1435

merged 3 commits into from
Apr 23, 2024

Conversation

pkosiec
Copy link
Collaborator

@pkosiec pkosiec commented Apr 23, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Fix integration and E2E tests after Cloud Dev update

Testing

See the CI status for the PR.

@pkosiec pkosiec added the bug Something isn't working label Apr 23, 2024
@pkosiec pkosiec added this to the v1.11.0 milestone Apr 23, 2024
@pkosiec pkosiec marked this pull request as ready for review April 23, 2024 09:53
@pkosiec pkosiec requested a review from PrasadG193 as a code owner April 23, 2024 09:53
@pkosiec pkosiec requested review from a team and madebyrogal April 23, 2024 09:53
@pkosiec pkosiec removed the request for review from madebyrogal April 23, 2024 09:55
@pkosiec
Revert "Test changes"
c96b5f0 
This reverts commit e9a5f53.
@pkosiec pkosiec enabled auto-merge (squash) April 23, 2024 09:58
madebyrogal
madebyrogal approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@madebyrogal madebyrogal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Didn't run tests locally.

@pkosiec pkosiec merged commit d4a164f into main Apr 23, 2024
20 checks passed
@pkosiec pkosiec deleted the fix-tests branch April 23, 2024 10:37
@pkosiec pkosiec added ci Related to CI pipelines other Internal, no user-facing changes. and removed bug Something isn't working labels May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mszostok mszostok mszostok approved these changes

@madebyrogal madebyrogal madebyrogal approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees
No one assigned
Labels
ci Related to CI pipelines other Internal, no user-facing changes.
Projects
Botkube
Status: Done
Milestone
v1.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pkosiec @madebyrogal @mszostok