Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration tests for DiscordApp #723

Merged
merged 22 commits into from
Sep 16, 2022
Merged

Add integration tests for DiscordApp #723

merged 22 commits into from
Sep 16, 2022

Conversation

ezodude
Copy link
Contributor

@ezodude ezodude commented Sep 6, 2022 •
edited
Loading

Description

Changes proposed in this pull request:

  • Added discord e2e tests while working through nuances of the Discord Rest API.
  • Can run the e2e tests locally successfully.
  • Introduced slack and discord BotDriver implementations to drive e2e tests.
  • New messaging platforms only need a driver implementation - no need to re-write the tests.
  • Updated GitHub CD actions and helm test config as necessary.
  • Updated docs to explain how to setup a discord server for local runs.
  • Added the required secrets required by the GitHub CD actions,
    • secrets.DISCORD_BOT_TOKEN
    • secrets.DISCORD_BOT_ID
    • secrets.DISCORD_TESTER_APP_TOKEN
    • secrets.DISCORD_GUILD_ID
  • NEW: Works with Interactive messaging tests.
  • NEW: Runs on Socket mode.

Related issue(s)

#307

@ezodude ezodude requested a review from a team September 6, 2022 14:21
@ezodude ezodude requested a review from PrasadG193 as a code owner September 6, 2022 14:21
@ezodude ezodude requested a review from huseyinbabal September 6, 2022 14:21
@ezodude ezodude marked this pull request as draft September 6, 2022 14:21
@ezodude ezodude mentioned this pull request Sep 6, 2022
Closed
@ezodude ezodude marked this pull request as ready for review September 9, 2022 11:29
@ezodude
Copy link
Contributor Author

ezodude commented Sep 9, 2022 •
edited
Loading

@huseyinbabal this PR is now ready for code review.

Regarding running the E2E tests, I can run them locally with you to ensure they run.

@ezodude
Copy link
Contributor Author

ezodude commented Sep 15, 2022

Moving this draft. The E2E tests need a slight adjustment to incorporate Slack interactive messaging.

(Slack interactive messaging tests were written against the legacy pre BotDriver approach)

@ezodude ezodude marked this pull request as draft September 15, 2022 08:55
huseyinbabal
huseyinbabal reviewed Sep 15, 2022
View reviewed changes
hack/goreleaser.sh Outdated Show resolved Hide resolved
huseyinbabal
huseyinbabal reviewed Sep 15, 2022
View reviewed changes
test/README.md Outdated Show resolved Hide resolved
@huseyinbabal
Copy link
Contributor

Moving this draft. The E2E tests need a slight adjustment to incorporate Slack interactive messaging.

(Slack interactive messaging tests were written against the legacy pre BotDriver approach)

Added my comments, hopefully will try to test it asap :) Thanks for this great milestone ;)

@ezodude ezodude mentioned this pull request Sep 16, 2022
Merged
@ezodude ezodude marked this pull request as ready for review September 16, 2022 13:10
@huseyinbabal
Copy link
Contributor

We paired with @ezodude and CI part is fine, merging...

@huseyinbabal huseyinbabal merged commit 31d555e into kubeshop:main Sep 16, 2022
huseyinbabal pushed a commit to huseyinbabal/botkube that referenced this pull request Sep 21, 2022
@ezodude @huseyinbabal
Add integration tests for DiscordApp (kubeshop#723)
499ef73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huseyinbabal huseyinbabal huseyinbabal approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ezodude @huseyinbabal