Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Discord e2e tests. #744

Merged
merged 5 commits into from
Sep 21, 2022
Merged

Fix Discord e2e tests. #744

merged 5 commits into from
Sep 21, 2022

Conversation

ezodude
Copy link
Contributor

@ezodude ezodude commented Sep 20, 2022 •
edited
Loading

Description

Changes proposed in this pull request:

  • Adds e2e-test-values with correct discord notification settings.
  • Updates Github Actions with missing Discord BotToken and BotID config.

Related issue(s)

#307

@ezodude ezodude requested a review from a team September 20, 2022 15:08
@ezodude ezodude requested a review from PrasadG193 as a code owner September 20, 2022 15:08
@ezodude ezodude requested a review from mszostok September 20, 2022 15:08
@ezodude
Copy link
Contributor Author

ezodude commented Sep 21, 2022

@mszostok this is ready for a review and deployment.

@ezodude ezodude changed the title Fix notification settings for Discord. Fix Discord e2e tests. Sep 21, 2022
mszostok
mszostok approved these changes Sep 21, 2022
View reviewed changes
Copy link
Collaborator

@mszostok mszostok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 hope that it will help 🤞

@ezodude ezodude merged commit c063bff into kubeshop:main Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mszostok mszostok mszostok approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ezodude @mszostok