Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add namespace label to default keyword, change filter placeholder #817

Merged
merged 3 commits into from
Oct 18, 2022
Merged

Add namespace label to default keyword, change filter placeholder #817

merged 3 commits into from
Oct 18, 2022

Conversation

mszostok
Copy link
Collaborator

@mszostok mszostok commented Oct 17, 2022 •
edited
Loading

Description

This PR address the Lacho feedback for the current implementation:

  • Add namespace label to the default keyword (ONLY to it, rest should be without it):
    Screen Shot 2022-10-17 at 11 27 03
    Screen Shot 2022-10-17 at 11 27 37

  • Change filter placeholder
    Screen Shot 2022-10-17 at 11 28 33

Related issue(s)

#748

@mszostok mszostok added the enhancement New feature or request label Oct 17, 2022
@mszostok mszostok requested a review from a team October 17, 2022 09:26
@mszostok mszostok requested a review from PrasadG193 as a code owner October 17, 2022 09:26
@mszostok mszostok requested a review from huseyinbabal October 17, 2022 09:26
@mszostok mszostok mentioned this pull request Oct 17, 2022
Closed
huseyinbabal
huseyinbabal approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@huseyinbabal huseyinbabal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one minor comment, works like a charm 🚀
Screen Shot 2022-10-18 at 11 47 22

@mszostok mszostok enabled auto-merge (squash) October 18, 2022 10:28
@mszostok mszostok merged commit 965f518 into kubeshop:main Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huseyinbabal huseyinbabal huseyinbabal approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mszostok @huseyinbabal