Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Testing" section in pull request template #976

Merged
merged 1 commit into from
Feb 9, 2023
Merged

Add "Testing" section in pull request template #976

merged 1 commit into from
Feb 9, 2023

Conversation

pkosiec
Copy link
Collaborator

@pkosiec pkosiec commented Feb 9, 2023

Description

Changes proposed in this pull request:

  • Add "Testing" section for PR template

@pkosiec pkosiec requested a review from a team February 9, 2023 08:47
@pkosiec pkosiec requested a review from PrasadG193 as a code owner February 9, 2023 08:47
@pkosiec pkosiec requested a review from mszostok February 9, 2023 08:47
@pkosiec pkosiec changed the title Add section in pull request template Add "Testing" section in pull request template Feb 9, 2023
mszostok
mszostok approved these changes Feb 9, 2023
View reviewed changes
Copy link
Collaborator

@mszostok mszostok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pkosiec pkosiec merged commit 66ec91a into kubeshop:main Feb 9, 2023
@pkosiec pkosiec deleted the update-pr-tpl branch February 9, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mszostok mszostok mszostok approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pkosiec @mszostok