Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rate limiting: option to group endpoints #144

Closed
dobegor opened this issue Aug 26, 2021 · 0 comments · Fixed by #153
Closed

rate limiting: option to group endpoints #144

dobegor opened this issue Aug 26, 2021 · 0 comments · Fixed by #153

Comments

@dobegor
Copy link
Contributor

dobegor commented Aug 26, 2021

Describe the enhancement you'd like to see

  1. have an rps and burst parameters, warn user that in case of a split in nginx-ingress these will be applied to each path separately (addressed by nginx-ingress: warn that path level rate limit is applied separately for each path #147)
  2. introduce a group parameter (string) which user can use to customise how endpoints are grouped in rate limiting - this is supported both in Ambassador and Traefik
  3. if no group is specified at the global level, treat it as a common rate limit (all endpoints are in the same group)
  4. if no group is specified at the path/operation level, treat it as a separate rate limit for this path/operation

Additional context
Add any other context, CLI input/output, etc. about the enhancement here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant