Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rate limit: add group option #153

Merged
merged 3 commits into from
Sep 2, 2021
Merged

rate limit: add group option #153

merged 3 commits into from
Sep 2, 2021

Conversation

dobegor
Copy link
Contributor

@dobegor dobegor commented Sep 1, 2021

This PR adds support to group rate-limited endpoints in Ambassador.

Fixes

Resolves #144.

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@dobegor dobegor requested a review from kylehodgetts September 1, 2021 19:21
@dobegor dobegor added this to the next milestone Sep 1, 2021
@kylehodgetts kylehodgetts self-requested a review September 2, 2021 09:59
kylehodgetts
kylehodgetts approved these changes Sep 2, 2021
View reviewed changes
Copy link
Contributor

@kylehodgetts kylehodgetts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dobegor dobegor merged commit 5b96f6f into main Sep 2, 2021
@dobegor dobegor deleted the dobegor/feature/144-rate-limiting-groups branch September 2, 2021 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylehodgetts kylehodgetts kylehodgetts approved these changes

Assignees
No one assigned
Labels
area/generators kind/feature
Projects
None yet
Milestone
next
Development

Successfully merging this pull request may close these issues.

rate limiting: option to group endpoints
2 participants
@dobegor @kylehodgetts