Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Base path in Linkerd wizard and Support timeouts in Ambassador wizard #129

Merged

Conversation

kylehodgetts
Copy link
Contributor

This PR adds support to the Linkerd wizard for setting the base path prefix.

This PR also adds support to the Ambassador wizard for setting both request and idle timeouts

resolves #81

Changes

  • Add path.base support to Linkerd wizard
  • Add timeouts.request_timeout and timeouts.idle_timeout support to Ambassador wizard
  • Go fmt those files that were unformatted

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@kylehodgetts kylehodgetts requested a review from dobegor August 19, 2021 09:48
@kylehodgetts kylehodgetts changed the title Kylehodgetts/enhancement/wizard include supported options Support Base path in Linkerd wizard and Support timeouts in Ambassador wizard Aug 19, 2021
Copy link
Member

@olensmar olensmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kylehodgetts kylehodgetts merged commit 13161e8 into main Aug 19, 2021
@kylehodgetts kylehodgetts deleted the kylehodgetts/enhancement/wizard-include-supported-options branch August 19, 2021 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wizard: support path.base option for linkerd
2 participants