Docs for Ambassador 2 + fixes for preview breakages #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
September 28, 2021 13:32
…omma separated string into its components for the mapping template cors section as Ambassador 2.0 doesn't support comma separated strings as paramters for cors anymore.
… must match an AmbassadorHost resource in order to work
… must match an AmbassadorHost resource in order to work
… iterate over them creating a yaml array in the resulting AmbassadorMapping resource
Tarick
approved these changes
Sep 28, 2021
| @@ -1,6 +1,7 @@ | |||
| openapi: 3.0.1 | |||
| x-kusk: | |||
| namespace: booksapp | |||
| host: "*" | |||
There was a problem hiding this comment.
I think this should be an array, not the string. I.e. if there is the need to support multiple hostnames for the same service (example.org, example.com). Not required for Ambassador support specifically though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist