Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Literal Rewrite Flag #187

Merged
merged 4 commits into from
Nov 9, 2021
Merged

Literal Rewrite Flag #187

merged 4 commits into from
Nov 9, 2021

Conversation

kylehodgetts
Copy link
Contributor

This PR resolves #186

Changes

  • add path option PathRewrite which allows base path to be overwritten with a literal value

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Tarick
Tarick previously approved these changes Nov 8, 2021
View reviewed changes
generators/ambassador/ambassador.go Outdated Show resolved Hide resolved
dobegor
dobegor previously approved these changes Nov 8, 2021
View reviewed changes
Copy link
Contributor

@dobegor dobegor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (other than the typo)!
On a side note, should we add validation to make sure that user knows that rewrite takes a higher precedence over trim_prefix?

@kylehodgetts kylehodgetts self-assigned this Nov 9, 2021
@dobegor dobegor dismissed stale reviews from Tarick and themself via f0571cb November 9, 2021 16:25
@dobegor dobegor merged commit 3b385fb into main Nov 9, 2021
@dobegor dobegor deleted the kylehodgetts/feature/186-literal-rewrite-flag branch November 9, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dobegor dobegor dobegor approved these changes

@Tarick Tarick Tarick left review comments

Assignees

@kylehodgetts kylehodgetts

Labels
area/generators kind/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Literal Rewrite flag on Ambassador2
3 participants
@kylehodgetts @Tarick @dobegor