Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add event recorder into PipelineRun reconciler #219

Merged
merged 1 commit into from
Sep 5, 2021
Merged

Add event recorder into PipelineRun reconciler #219

merged 1 commit into from
Sep 5, 2021

Conversation

JohnNiang
Copy link
Member

What this PR dose

Add event recorder into PipelineRun reconciler

Why we need it

Please see #210 (comment)

Special notes

image

/kind feature

@ks-ci-bot ks-ci-bot added kind/feature Categorizes issue or PR as related to a new feature. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 2, 2021
@codecov
Copy link

codecov bot commented Sep 2, 2021 •
edited
Loading

Codecov Report

Merging #219 (125f81d) into master (5c93d49) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #219      +/-   ##
=========================================
- Coverage    5.72%   5.71%   -0.01%     
=========================================
  Files          80      80              
  Lines       21416   21421       +5     
=========================================
  Hits         1225    1225              
- Misses      20118   20123       +5     
  Partials       73      73
Flag Coverage Δ
unittests 5.71% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lers/jenkins/pipelinerun/pipelinerun_controller.go 4.72% <0.00%> (-0.20%) ⬇️
pkg/api/devops/v1alpha4/pipelinerun_types.go 9.67% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c93d49...125f81d. Read the comment docs.

@JohnNiang
Copy link
Member Author

JohnNiang commented Sep 3, 2021 •
edited
Loading

When a parameterized Pipeline is triggered without parameters, the warning event appears as follow:

image

If we want get more details about the error, https://github.com/jenkins-zh/jenkins-client need to be enhanced.

@ks-ci-bot ks-ci-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 3, 2021
@JohnNiang JohnNiang requested a review from LinuxSuRen September 3, 2021 05:39
LinuxSuRen
LinuxSuRen reviewed Sep 3, 2021
View reviewed changes
Copy link
Member

@LinuxSuRen LinuxSuRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2021
@JohnNiang
Copy link
Member Author

/label tide/merge-method-rebase

@JohnNiang JohnNiang mentioned this pull request Sep 3, 2021
Open
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang, LinuxSuRen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2021
@JohnNiang
Copy link
Member Author

JohnNiang commented Sep 5, 2021 •
edited
Loading

Hi @LinuxSuRen , can this PR get ready for merging? Because I see both approved and lgtm tags here added 2 days ago.

@LinuxSuRen LinuxSuRen merged commit 5012c31 into kubesphere:master Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinuxSuRen LinuxSuRen LinuxSuRen approved these changes

Assignees

@LinuxSuRen LinuxSuRen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JohnNiang @ks-ci-bot @LinuxSuRen