-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ssh formatting exception bug when executing commands #2406
fix: ssh formatting exception bug when executing commands #2406
Conversation
WARNING: Use `nolint:gosec` annotation
This PR has multiple commits, and the default merge method is: squash. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This way can correctly execute multi-line commands, but use one |
Quality Gate passedIssues Measures |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: dbbDylan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
e4957a6
into
kubesphere:feature-gitops
What type of PR is this?
/kind bug
What this PR does / why we need it:
fmt.Sprintf
may cause unexpected error when executing a single command as a result of multiple double-quote transpositions. The more safe way is to useexec.Command
function.file://
tofile:///
ininit_repository.yaml
For more information on release notes see: https://github.com/kubernetes/community/blob/master/contributors/guide/release-notes.md
-->