-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MTV-1596 | Add new NetworkNameTemplate field to plan CR #1327
base: main
Are you sure you want to change the base?
MTV-1596 | Add new NetworkNameTemplate field to plan CR #1327
Conversation
80d9785
to
775d5cd
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1327 +/- ##
==========================================
- Coverage 15.45% 15.33% -0.13%
==========================================
Files 112 112
Lines 23377 23620 +243
==========================================
+ Hits 3613 3621 +8
- Misses 19479 19711 +232
- Partials 285 288 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
775d5cd
to
650e7c4
Compare
0481ec9
to
8538f45
Compare
|
||
networkName, err = r.executeTemplate(networkNameTemplate, &templateData) | ||
if err != nil { | ||
// fallback to default name and reset error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe adding a log that the template execution failed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re based and added a log line
8538f45
to
5a5cd54
Compare
Signed-off-by: yaacov <[email protected]>
5a5cd54
to
c23efaf
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Ref:
https://issues.redhat.com/browse/MTV-1596
RFE:
Requesting the ability for choosing a custom name for the network and disks during migration for VM's. Currently migrations end up with 'net-0' or 'vol-1' and cannot be modified. A newly created vm typically allows for you to name these.
Fix:
Add an optional network template:
In the plan YAML:
Screenshots:
![plan-yaml-custom-net](https://private-user-images.githubusercontent.com/2181522/408881400-8e8de3af-3667-4a0f-82fc-71cdfe3309b8.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyNzkzNjUsIm5iZiI6MTczOTI3OTA2NSwicGF0aCI6Ii8yMTgxNTIyLzQwODg4MTQwMC04ZThkZTNhZi0zNjY3LTRhMGYtODJmYy03MWNkZmUzMzA5YjgucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTFUMTMwNDI1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YWJmZjA1NzJhMjVhOWRlMmNiZWI4YzU3ZWY2YjdlNjYxYTQ3NGNhZDJhYWRiMWQwY2VhMWQyMDM1NjcxNmUzMiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.joVF6H9dRS7Rf-PWN9IYr2ZaIlZDxLMcJsOf-_SKkRg)