Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert: import vela images in darwin/arm64 #109

Open
wants to merge 1 commit into
base: release-1.6
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions pkg/vela/kubevela.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import (
"os"
"os/exec"
"path"
"runtime"
"strings"

"github.com/oam-dev/kubevela/pkg/utils/system"
Expand Down Expand Up @@ -66,10 +67,10 @@ func PrepareVelaChart(ctx *apis.Context) error {

// LoadVelaImages load vela-core and velaUX images
func LoadVelaImages(ctx *apis.Context) error {
// if runtime.GOOS == apis.GoosDarwin && runtime.GOARCH == "arm64" {
// info("Skip importing vela-core and VelaUX image on darwin-arm64")
// return nil
// }
if runtime.GOOS == apis.GoosDarwin && runtime.GOARCH == "arm64" {
info("Skip importing vela-core and VelaUX image on darwin-arm64")
return nil
}
var (
err error
imageTar string
Expand Down