-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: support get secret from project config for helm chart #698
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #698 +/- ##
==========================================
- Coverage 60.34% 60.24% -0.10%
==========================================
Files 94 99 +5
Lines 17622 17994 +372
==========================================
+ Hits 10634 10841 +207
- Misses 5679 5811 +132
- Partials 1309 1342 +33
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 19 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
@caiqi1111 Let's change the frontend code to fix this issue completely. The related code path |
@barnettZQG I have changed the frontend code. please review again |
@caiqi1111 Did you rebase the latest code? |
@barnettZQG I use ”git pull“ get the latest code and solve the conflict, did not use git rebase |
@caiqi1111 Please rebase the latest code. |
Signed-off-by: caiqi <[email protected]>
Signed-off-by: caiqi <[email protected]>
Signed-off-by: caiqi <[email protected]>
Signed-off-by: caiqi <[email protected]>
Signed-off-by: caiqi <[email protected]>
Signed-off-by: caiqi <[email protected]>
Signed-off-by: caiqi <[email protected]>
@barnettZQG I have rebased the latest code now. |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description of your changes
Support get secret from project config for helm chart.
-->
Fixes #
I have:
yarn lint
to ensure the frontend changes are ready for review.make reviewable
to ensure the server changes are ready for review.backport release-x.y
labels to auto-backport this PR if necessary.Special notes for your reviewer