Fix: Load the category of the workflow step definition. #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeerajGartia21
requested review from
barnettZQG,
yangsoon and
FogDong
as code owners
|
@NeerajGartia21 Thanks for your first PR, please sign the DCO. |
barnettZQG
reviewed
Mar 20, 2023
barnettZQG
reviewed
Mar 20, 2023
packages/velaux-ui/src/components/WorkflowStudio/type-select.tsx
Outdated
Show resolved
Hide resolved
barnettZQG
reviewed
Mar 20, 2023
Signed-off-by: Neeraj Gartia <[email protected]>
Signed-off-by: Neeraj Gartia <[email protected]>
Signed-off-by: Neeraj Gartia <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #711 +/- ##
==========================================
+ Coverage 60.34% 60.38% +0.03%
==========================================
Files 94 94
Lines 17622 17623 +1
==========================================
+ Hits 10634 10641 +7
+ Misses 5679 5666 -13
- Partials 1309 1316 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
Please rebase the branch from the main. |
Signed-off-by: Neeraj Gartia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #702
I have:
yarn lintto ensure the frontend changes are ready for review.make reviewableto ensure the server changes are ready for review.backport release-x.ylabels to auto-backport this PR if necessary.Special notes for your reviewer
I have added the descriptions to the workflow steps on my own. Please suggest changes to that.