Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fix some typo errors #890

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Fix: fix some typo errors #890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/server/domain/service/util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ func guaranteePolicyExist(c []string, policy string) ([]string, bool) {
return append(c, policy), true
}

// guaranteePolicyNotExist check the slice whether caontain the target policy, if yes delete
// guaranteePolicyNotExist check the slice whether contain the target policy, if yes delete
// and tell invoker whether should update the policy
func guaranteePolicyNotExist(c []string, policy string) ([]string, bool) {
res := make([]string, len(c))
Expand Down
4 changes: 2 additions & 2 deletions pkg/server/interfaces/api/application.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,7 @@
Filter(c.appCheckFilter).
Filter(c.WorkflowAPI.workflowCheckFilter).
Param(ws.PathParameter("appName", "identifier of the application.").DataType("string").Required(true)).
Param(ws.PathParameter("workflowName", "identifier of the workfloc.").DataType("string")).
Param(ws.PathParameter("workflowName", "identifier of the workflow.").DataType("string")).

Check warning on line 497 in pkg/server/interfaces/api/application.go

View check run for this annotation

Codecov / codecov/patch

pkg/server/interfaces/api/application.go#L497 

Added line #L497 was not covered by tests
Metadata(restfulspec.KeyOpenAPITags, tags).
Filter(c.WorkflowAPI.workflowCheckFilter).
Returns(200, "create success", apis.DetailWorkflowResponse{}).
Expand All @@ -513,7 +513,7 @@
Writes(apis.DetailWorkflowResponse{}).Do(returns500))

ws.Route(ws.DELETE("/{appName}/workflows/{workflowName}").To(c.WorkflowAPI.deleteWorkflow).
Doc("deletet workflow").
Doc("delete workflow").

Check warning on line 516 in pkg/server/interfaces/api/application.go

View check run for this annotation

Codecov / codecov/patch

pkg/server/interfaces/api/application.go#L516 

Added line #L516 was not covered by tests
Metadata(restfulspec.KeyOpenAPITags, tags).
Filter(c.RbacService.CheckPerm("application/workflow", "delete")).
Filter(c.appCheckFilter).
Expand Down
2 changes: 1 addition & 1 deletion pkg/server/interfaces/api/target.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@
Writes(apis.DetailTargetResponse{}).Do(returns500))

ws.Route(ws.DELETE("/{targetName}").To(dt.deleteTarget).
Doc("deletet Target").
Doc("delete Target").

Check warning on line 98 in pkg/server/interfaces/api/target.go

View check run for this annotation

Codecov / codecov/patch

pkg/server/interfaces/api/target.go#L98 

Added line #L98 was not covered by tests
Metadata(restfulspec.KeyOpenAPITags, tags).
Filter(dt.targetCheckFilter).
Filter(dt.RbacService.CheckPerm("target", "delete")).
Expand Down
Loading