Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-notes: Ping the tool to v0.13.0 #1426

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

qinqon
Copy link
Collaborator

@qinqon qinqon commented Oct 5, 2022

What this PR does / why we need it:
Latest releas-notes tool is using golang 1.19 and is using new golang features so the tool does not compile with go1.17 from CNAO project. This change pin it to latest go1.17 version v0.13.0.

NONE

Latest releas-notes tool is using golang 1.19 and is using new golang
features so the tool does not compile with go1.17 from CNAO project.
This change pin it to latest go1.17 version v0.13.0.

Signed-off-by: Enrique Llorente <[email protected]>
@qinqon
Copy link
Collaborator Author

qinqon commented Oct 5, 2022

/cherry-pick release-0.76
/cherry-pick release-0.65

Copy link
Member

@phoracek phoracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Oct 5, 2022
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: phoracek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS labels Oct 5, 2022
@kubevirt-bot
Copy link
Collaborator

@qinqon: once the present PR merges, I will cherry-pick it on top of release-0.76 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.76
/cherry-pick release-0.65

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2022
@kubevirt-bot kubevirt-bot merged commit 71c56e8 into kubevirt:main Oct 5, 2022
@kubevirt-bot
Copy link
Collaborator

@qinqon: new pull request created: #1427

In response to this:

/cherry-pick release-0.76
/cherry-pick release-0.65

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot
Copy link
Collaborator

@qinqon: new pull request created: #1428

In response to this:

/cherry-pick release-0.76
/cherry-pick release-0.65

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants