Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support KubeSecondaryDNS plugin #1451

Merged
merged 1 commit into from
Dec 5, 2022
Merged

Support KubeSecondaryDNS plugin #1451

merged 1 commit into from
Dec 5, 2022

Conversation

oshoval
Copy link
Collaborator

@oshoval oshoval commented Nov 14, 2022 •
edited
Loading

What this PR does / why we need it:
Integrate KubeSecondaryDNS as part of CNAO.
See https://github.com/kubevirt/kubesecondarydns

core-dns-image can be used in order to generate a CSV manifest
with custom image.

Prow job kubevirt/project-infra#2459

Notes:
Once this PR is merged, need to:

  • Make pull-e2e-cnao-kube-secondary-dns-functests required.
  • PSA would be added on a follow PR.

Special notes for your reviewer:

Release note:

Support KubeSecondaryDNS component by CNAO

@kubevirt-bot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Nov 14, 2022
@oshoval oshoval force-pushed the secondary branch 2 times, most recently from 7f62cc1 to add05d9 Compare November 14, 2022 13:30
@oshoval oshoval mentioned this pull request Nov 14, 2022
Merged
@oshoval oshoval force-pushed the secondary branch 7 times, most recently from 224ebbf to e1b71c7 Compare November 21, 2022 12:02
@oshoval oshoval changed the title [WIP] Support KubeSecondaryDns plugin Support KubeSecondaryDns plugin Nov 23, 2022
@oshoval oshoval changed the title Support KubeSecondaryDns plugin Support KubeSecondaryDNS plugin Nov 23, 2022
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Nov 23, 2022
@oshoval oshoval force-pushed the secondary branch 3 times, most recently from e9a1dc0 to 495ff94 Compare November 24, 2022 11:43
@oshoval
Copy link
Collaborator Author

oshoval commented Nov 24, 2022 •
edited
Loading

/test pull-e2e-cnao-kube-secondary-dns-functests

https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_cluster-network-addons-operator/1451/pull-e2e-cnao-kube-secondary-dns-functests/1595755279612383232
passed (stub e2e)

@oshoval oshoval force-pushed the secondary branch 3 times, most recently from b232ddd to 0e11bc2 Compare November 28, 2022 09:07
@oshoval
Copy link
Collaborator Author

oshoval commented Nov 28, 2022

Ready for review, thanks

@oshoval
Copy link
Collaborator Author

oshoval commented Nov 28, 2022

/test pull-e2e-cnao-kube-secondary-dns-functests

@oshoval
Copy link
Collaborator Author

oshoval commented Nov 28, 2022

/test pull-e2e-cnao-kube-secondary-dns-functests

@oshoval
Copy link
Collaborator Author

oshoval commented Nov 28, 2022

#1451 (comment)
code duplication warning is known and won't be handled by this PR

@oshoval
Copy link
Collaborator Author

oshoval commented Nov 28, 2022

/cc @AlonaKaplan @dteplits

@oshoval
Copy link
Collaborator Author

oshoval commented Nov 28, 2022

/test pull-e2e-cnao-kube-secondary-dns-functests

@oshoval
Copy link
Collaborator Author

oshoval commented Nov 28, 2022

/retest-required

@oshoval
Copy link
Collaborator Author

oshoval commented Nov 28, 2022 •
edited
Loading

Not to be merged until we change the project reference (as the project was moved under kubevirt)

@oshoval
Copy link
Collaborator Author

oshoval commented Nov 28, 2022

/hold

see comment above

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 28, 2022
@oshoval
Support KubeSecondaryDNS plugin
e29a75c 
Integrate KubeSecondaryDNS as part of CNAO.
"core-dns-image" can be used in order to generate a CSV manifest
with custom image.

Signed-off-by: Or Shoval <[email protected]>
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
5.1% 5.1% Duplication

@oshoval
Copy link
Collaborator Author

oshoval commented Nov 29, 2022

Updated to use github.com/kubevirt/kubesecondarydns

@oshoval
Copy link
Collaborator Author

oshoval commented Nov 29, 2022 •
edited
Loading

/test pull-e2e-cnao-kube-secondary-dns-functests

EDIT
passed
https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_cluster-network-addons-operator/1451/pull-e2e-cnao-kube-secondary-dns-functests/1597559696368078848

@oshoval
Copy link
Collaborator Author

oshoval commented Nov 29, 2022

/hold cancel

Ready for review, thanks

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 29, 2022
RamLavi
RamLavi reviewed Dec 4, 2022
View reviewed changes
README.md Show resolved Hide resolved
RamLavi
RamLavi reviewed Dec 4, 2022
View reviewed changes
README.md Show resolved Hide resolved
RamLavi
RamLavi approved these changes Dec 5, 2022
View reviewed changes
Copy link
Collaborator

@RamLavi RamLavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2022
@RamLavi
Copy link
Collaborator

RamLavi commented Dec 5, 2022

/approve

@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RamLavi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2022
@kubevirt-bot kubevirt-bot merged commit 1b4fc13 into kubevirt:main Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RamLavi RamLavi RamLavi approved these changes

@phoracek phoracek Awaiting requested review from phoracek

@AlonaKaplan AlonaKaplan Awaiting requested review from AlonaKaplan

@dteplits dteplits Awaiting requested review from dteplits

Assignees

@RamLavi RamLavi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oshoval @kubevirt-bot @RamLavi