-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitly request "use" verb on SCC #1455
Conversation
In order to notify pod-security.kubernetes.io that we intent to create (potentially privileged) SCCs, so it labels us as "privileged", we have to explicitly request "use" verb for scc. With this change, CNAO's namespace is marked as pod-security.kubernetes.io/enforce: priviledged even before we deploy any of our privileged components. This assures that CNAO does not show up in audit logs. Signed-off-by: Petr Horáček <[email protected]>
Skipping CI for Draft Pull Request. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qinqon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/cherry-pick release-0.79 |
@phoracek: new pull request created: #1457 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-0.76 |
@phoracek: new pull request created: #1458 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
In order to notify pod-security.kubernetes.io that we intent to create (potentially privileged) SCCs, so it labels us as "privileged", we have to explicitly request "use" verb for scc.
With this change, CNAO's namespace is marked as
pod-security.kubernetes.io/enforce: priviledged
even before we deploy any of our privileged components. This assures that CNAO does not show up in audit logs.Special notes for your reviewer:
Release note: