Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump linux bridge CNI #1535

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Conversation

phoracek
Copy link
Member

@phoracek phoracek commented Apr 19, 2023

What this PR does / why we need it:

This introduces bug fixes resolving issues with VLAN 1 leakage and performance issues of MAC spoof filtering [2].

[1] containernetworking/plugins#667
[2] https://bugzilla.redhat.com/show_bug.cgi?id=2173485

Special notes for your reviewer:

Generated by referencing the latest plugins commit from components.yaml, running PUSH_IMAGES=yes make bump-linux-bridge and replacing tags with digests.

Release note:

Fix PVID bug and performance issues of the bridge CNI 

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Apr 19, 2023
This introduces bug fixes resolving issues with VLAN 1 leakage and
performance issues of MAC spoof filtering [2].

[1] containernetworking/plugins#667
[2] https://bugzilla.redhat.com/show_bug.cgi?id=2173485

Signed-off-by: Petr Horacek <[email protected]>
@phoracek phoracek force-pushed the bump_bridge_cni_spoof branch from aaa146b to 03b75e9 Compare April 19, 2023 11:54
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@maiqueb maiqueb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2023
@phoracek
Copy link
Member Author

/approve

@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: phoracek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2023
@kubevirt-bot kubevirt-bot merged commit 755a53e into kubevirt:main Apr 19, 2023
@maiqueb
Copy link
Contributor

maiqueb commented Apr 20, 2023

/cherry-pick release-0.85

@kubevirt-bot
Copy link
Collaborator

@maiqueb: #1535 failed to apply on top of branch "release-0.85":

Applying: Bump linux bridge CNI
Using index info to reconstruct a base tree...
M	components.yaml
M	pkg/components/components.go
M	test/releases/99.0.0.go
Falling back to patching base and 3-way merge...
Auto-merging test/releases/99.0.0.go
Auto-merging pkg/components/components.go
Auto-merging components.yaml
CONFLICT (content): Merge conflict in components.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Bump linux bridge CNI
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-0.85

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

maiqueb pushed a commit to maiqueb/cluster-network-addons-operator that referenced this pull request Apr 20, 2023
This introduces bug fixes resolving issues with VLAN 1 leakage and
performance issues of MAC spoof filtering [2].

[1] containernetworking/plugins#667
[2] https://bugzilla.redhat.com/show_bug.cgi?id=2173485

Signed-off-by: Petr Horacek <[email protected]>
(cherry picked from commit 755a53e)
kubevirt-bot pushed a commit that referenced this pull request Apr 20, 2023
This introduces bug fixes resolving issues with VLAN 1 leakage and
performance issues of MAC spoof filtering [2].

[1] containernetworking/plugins#667
[2] https://bugzilla.redhat.com/show_bug.cgi?id=2173485

Signed-off-by: Petr Horacek <[email protected]>
(cherry picked from commit 755a53e)

Co-authored-by: Petr Horacek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants