Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.49] Add DataImportCron CronJobs Proxy support #2462

Conversation

arnongilboa
Copy link
Collaborator

Manual backport of #2455

Signed-off-by: Arnon Gilboa [email protected]

What this PR does / why we need it:
Use proxy certificates when creating DataImportCron CronJobs, so the pods won't fail on certificate issues when proxy is configured. cdi-source-update-poller was also fixed to use the proxy certificates.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

Add DataImportCron CronJobs Proxy support

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Nov 5, 2022
@awels
Copy link
Member

awels commented Nov 9, 2022

/retest

@maya-r
Copy link
Contributor

maya-r commented Nov 10, 2022

oops, probably should have omitted fossa

@maya-r
Copy link
Contributor

maya-r commented Nov 10, 2022

/override pull-containerized-data-importer-fossa
wondering if I can do this

@kubevirt-bot
Copy link
Contributor

@maya-r: maya-r unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file.

In response to this:

/override pull-containerized-data-importer-fossa
wondering if I can do this

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dhiller
Copy link
Contributor

dhiller commented Nov 10, 2022

/override pull-containerized-data-importer-fossa

@kubevirt-bot
Copy link
Contributor

@dhiller: Overrode contexts on behalf of dhiller: pull-containerized-data-importer-fossa

In response to this:

/override pull-containerized-data-importer-fossa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@awels
Copy link
Member

awels commented Nov 10, 2022

/test pull-cdi-generate-verify

@kubevirt-bot
Copy link
Contributor

@awels: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-containerized-data-importer-e2e-ceph-1.49
  • /test pull-containerized-data-importer-e2e-hpp-previous-1.49

The following commands are available to trigger optional jobs:

  • /test pull-cdi-apidocs-1.49
  • /test pull-cdi-generate-verify-1.49
  • /test pull-cdi-linter-1.49
  • /test pull-cdi-unit-test-1.49

Use /test all to run all jobs.

In response to this:

/test pull-cdi-generate-verify

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@awels
Copy link
Member

awels commented Nov 10, 2022

/retest-required

1 similar comment
@awels
Copy link
Member

awels commented Nov 10, 2022

/retest-required

@awels
Copy link
Member

awels commented Nov 10, 2022

/test pull-cdi-generate-verify-1.49

@awels
Copy link
Member

awels commented Nov 10, 2022

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2022
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awels

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2022
@kubevirt-bot kubevirt-bot merged commit c2d8871 into kubevirt:release-v1.49 Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants