Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LINSTOR to known provisioners #2537

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Add LINSTOR to known provisioners #2537

merged 1 commit into from
Jan 11, 2023

Conversation

kvaps
Copy link
Member

@kvaps kvaps commented Jan 9, 2023 •
edited
Loading

What this PR does / why we need it:

Add LINSTOR to known provisioners.
This will automatically set optimized parameters for newly created DataVolumes:

accessModes:
- ReadWriteMany
volumeMode: Block

Special notes for your reviewer:

Release note:

Add LINSTOR to known provisioners

/cc @WanzenBug ^^

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 9, 2023
@kvaps
Copy link
Member Author

kvaps commented Jan 9, 2023

/assign @awels

@akalenyu
Copy link
Collaborator

Thank you!

From a quick look at the repo, it seems they also do ROX for both Block & Filesystem
https://github.com/piraeusdatastore/linstor-csi/blob/master/CHANGELOG.md?plain=1#L253

@kvaps
Copy link
Member Author

kvaps commented Jan 10, 2023

Sure, added

@akalenyu
Copy link
Collaborator

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 10, 2023
@mhenriks
Copy link
Member

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mhenriks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2023
@kubevirt-bot kubevirt-bot merged commit 63960aa into kubevirt:main Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aglitke aglitke Awaiting requested review from aglitke

@mhenriks mhenriks Awaiting requested review from mhenriks

Assignees

@awels awels

@akalenyu akalenyu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kvaps @akalenyu @mhenriks @kubevirt-bot @awels