Fix DataImportCron PVC timestamping

[arnongilboa]

Signed-off-by: Arnon Gilboa [email protected]

What this PR does / why we need it:
DataImportCron PVC garbage collection is LRU-based, so it's broken when PVCs are not timestamped.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes bz #2165793

Special notes for your reviewer:

Release note:

Fix DataImportCron PVC timestamping

[awels]

/retest-required
/lgtm
/approve

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awels

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [awels]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[arnongilboa]

/retest

[arnongilboa]

/retest

[arnongilboa]

/hold

[aglitke]

@arnongilboa Can you do a backport to release-v1.55 ?

[arnongilboa]

/cherrypick release-v1.55

[kubevirt-bot]

@arnongilboa: #2566 failed to apply on top of branch "release-v1.55":

Applying: Fix DataImportCron PVC timestamping
Using index info to reconstruct a base tree...
M	pkg/controller/dataimportcron-controller.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/controller/dataimportcron-controller.go
CONFLICT (content): Merge conflict in pkg/controller/dataimportcron-controller.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix DataImportCron PVC timestamping
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-v1.55

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[arnongilboa]

@arnongilboa Can you do a backport to release-v1.55 ?

@aglitke sure, working on a manual backport

[arnongilboa]

/unhold
no idea how it got merged before removing it...

[awels]

You held it after the merge.

[arnongilboa]

You held it after the merge.

oh, so I just didn't notice it merged. It seems I introduced a short timeout issue which may cause flackiness. 10 sec was nice for local debugging but not for CI...

https://github.com/kubevirt/containerized-data-importer/blob/main/tests/dataimportcron_test.go#L279