Update golang to 1.19.4 and kubevirtci to latest #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
release-note
awels
force-pushed
the
update_kubevirtci_golang_119
branch
5 times, most recently
from
628986f to
12ab67b
Compare
Signed-off-by: Alexander Wels <[email protected]>
awels
force-pushed
the
update_kubevirtci_golang_119
branch
from
12ab67b to
16ed3a2
Compare
akalenyu
reviewed
Jan 12, 2023
| @@ -14,13 +14,13 @@ | |||
|
|
|||
| .PHONY: cluster-up cluster-down cluster-sync cluster-clean | |||
|
|
|||
| KUBEVIRT_PROVIDER?=k8s-1.23 | |||
| KUBEVIRT_PROVIDER?=k8s-1.25 | |||
There was a problem hiding this comment.
may want 1.26 now, kubevirt/kubevirt already has required lanes
plus pretty sure main==1.26 at this point
There was a problem hiding this comment.
I know 1.26 is available, I wanted to stick to 1.25 for no particular reason other than that I am not 100% sure 1.26 is stable yet.
|
/lgtm |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awels The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexander Wels [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: