Refactor digeser to fix sonarClaud issue #1080
Conversation
kubevirt-bot
added
release-note-none
|
hco-e2e-image-index-azure, hco-e2e-image-index-aws lanes succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
nunnatsa
force-pushed
the
more-sonar-fix
branch
from
c5791e6 to
bbe8d49
Compare
|
hco-e2e-image-index-azure, hco-e2e-image-index-aws lanes succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zcahana The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
In tools/csv-merger/csv-merger.go: * Rename function gen_hco_crds to match the regular expression ^(_|[a-zA-Z0-9]+)$ * Define a constant instead of duplicating this literal "alm-examples" 3 times * 8 X Rename this local variable to match the regular expression "^(_|[a-zA-Z0-9]+)$".Why is this an issue? * func validateNoApiOverlap: Refactor this method to reduce its Cognitive Complexity from 41 to the 15 allowed. In `tools/digester/main.go`: * Refactor digeser to fix sonarClaud issue: Refactor this method to reduce its Cognitive Complexity from 26 to the 15 allowed. Signed-off-by: Nahshon Unna-Tsameret <[email protected]>
nunnatsa
force-pushed
the
more-sonar-fix
branch
from
bbe8d49 to
a72c589
Compare
kubevirt-bot
removed
lgtm
|
Re-lgtm'ing since the latest push is just a commit-msg edit. |
|
hco-e2e-upgrade-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-azure, ci/prow/hco-e2e-upgrade-prev-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@nunnatsa: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/override-bot |
|
hco-e2e-image-index-azure, hco-e2e-image-index-aws lanes succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
In order to reduce the number of the "critical" sonarClaud warning, the PR fixes the following warning:
In
tools/digester/main.go: Refactor this method to reduce its Cognitive Complexity from 26 to the 15 allowed.Signed-off-by: Nahshon Unna-Tsameret [email protected]
Release note: