-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.3] avoid enabling Sidecar FG #1177
[release-1.3] avoid enabling Sidecar FG #1177
Conversation
Sidecar FG was enable by default on the kubevirt configMap as a fix for: https://bugzilla.redhat.com/1745328 but now we don't see anymore the need for that. Let's disable it by default. The same feature gate has been already removed in the master branch with #1167 for the same reason. The two branches are now too different to let us try a real cherry-pick. Fixes: https://bugzilla.redhat.com/1933070 Signed-off-by: Simone Tiraboschi <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
hco-e2e-upgrade-prev-azure lane succeeded. |
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-azure, ci/prow/hco-e2e-upgrade-prev-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
hco-e2e-upgrade-aws lane succeeded. |
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-aws, ci/prow/hco-e2e-image-index-gcp, ci/prow/hco-e2e-upgrade-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@tiraboschi: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nunnatsa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override-bot |
hco-e2e-image-index-azure lane succeeded. |
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
hco-e2e-image-index-azure lane succeeded. |
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sidecar FG was enable by default on the
kubevirt configMap as a fix for:
https://bugzilla.redhat.com/1745328
but now we don't see anymore the need
for that.
Let's disable it by default.
The same feature gate has been already
removed in the master branch with #1167
for the same reason.
The two branches are now too different to
let us try a real cherry-pick.
Fixes: https://bugzilla.redhat.com/1933070
Signed-off-by: Simone Tiraboschi [email protected]
Release note: