Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.3] Update Images Digests #1192

Merged
merged 1 commit into from
Mar 17, 2021
Merged

[release-1.3] Update Images Digests #1192

merged 1 commit into from
Mar 17, 2021

Conversation

orenc1
Copy link
Collaborator

@orenc1 orenc1 commented Mar 17, 2021

Signed-off-by: orenc1 [email protected]

Release note:

update image digests before release

@orenc1 orenc1 requested a review from tiraboschi March 17, 2021 10:19
@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/M labels Mar 17, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2021
@tiraboschi
Copy link
Member

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2021
@nunnatsa
Copy link
Collaborator

@tiraboschi - this should be copied to master 1.3 directory, because it will break the upgrade-prev lanes.

@tiraboschi
Copy link
Member

@tiraboschi - this should be copied to master 1.3 directory, because it will break the upgrade-prev lanes.

Yes, I'll manually do it.
Then we should find a mechanism to automate this.

@tiraboschi tiraboschi mentioned this pull request Mar 17, 2021
Merged
@orenc1
Copy link
Collaborator Author

orenc1 commented Mar 17, 2021

@tiraboschi - this should be copied to master 1.3 directory, because it will break the upgrade-prev lanes.

Yes, I'll manually do it.
Then we should find a mechanism to automate this.

We can have a workflow that mirrors the contents of the manifests version folder of a release branch, to it's respective version folder in master, which can be triggered by a special keyword we define in the PR (for example).
Anyway it must go through a PR to master...

@hco-bot
Copy link
Collaborator

hco-bot commented Mar 17, 2021

hco-e2e-upgrade-prev-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-azure
hco-e2e-image-index-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-aws
hco-e2e-image-index-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-aws, ci/prow/hco-e2e-image-index-gcp, ci/prow/hco-e2e-upgrade-prev-azure

In response to this:

hco-e2e-upgrade-prev-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-azure
hco-e2e-image-index-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-aws
hco-e2e-image-index-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@orenc1
Copy link
Collaborator Author

orenc1 commented Mar 17, 2021

/retest

kubevirt-bot pushed a commit that referenced this pull request Mar 17, 2021
@tiraboschi
Align 1.3.0 manifests for upgrade testing (#1193)
8c4935e 
Align 1.3.0 manifests after #1192
to properly feed the upgrade testing lanes.

We should still figure out how to properly
automate this.

Signed-off-by: Simone Tiraboschi <[email protected]>
@tiraboschi
Copy link
Member

/override-bot

@openshift-ci
Copy link

openshift-ci bot commented Mar 17, 2021

@orenc1: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/hco-e2e-image-index-aws 7e2acab link /test hco-e2e-image-index-aws
ci/prow/hco-e2e-upgrade-aws 7e2acab link /test hco-e2e-upgrade-aws
ci/prow/hco-e2e-image-index-gcp 7e2acab link /test hco-e2e-image-index-gcp

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hco-bot
Copy link
Collaborator

hco-bot commented Mar 17, 2021

hco-e2e-image-index-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp
hco-e2e-upgrade-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-aws

@kubevirt-bot
Copy link
Contributor

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp, ci/prow/hco-e2e-upgrade-aws

In response to this:

hco-e2e-image-index-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp
hco-e2e-upgrade-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot merged commit 1349061 into kubevirt:release-1.3 Mar 17, 2021
@orenc1 orenc1 deleted the release-1.3_update_digests branch April 25, 2021 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiraboschi tiraboschi tiraboschi approved these changes

@andreyod andreyod Awaiting requested review from andreyod

@nunnatsa nunnatsa Awaiting requested review from nunnatsa

Assignees

@tiraboschi tiraboschi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@orenc1 @tiraboschi @kubevirt-bot @nunnatsa @hco-bot