Introduce a new jsonpatch annotation for SSP #2229

tiraboschi · 2023-02-06T17:15:02Z

Introduce an additional jsonpatch annotation
to let the cluster admin override also SSP
configuration for test/dev purposes.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2166923 JIRA-ticket: https://issues.redhat.com/browse/CNV-25035

Signed-off-by: stirabos [email protected]

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

Release note:

Introduce a new jsonpatch annotation for SSP

hco-bot · 2023-02-06T18:37:33Z

okd-hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-gcp
hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-azure

kubevirt-bot · 2023-02-06T18:37:37Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-azure, ci/prow/okd-hco-e2e-upgrade-index-gcp

In response to this:

okd-hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-gcp
hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-02-06T18:44:14Z

okd-hco-e2e-image-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-gcp

kubevirt-bot · 2023-02-06T18:44:22Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-image-index-gcp

In response to this:

okd-hco-e2e-image-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-02-06T19:17:29Z

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

kubevirt-bot · 2023-02-06T19:17:33Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp

In response to this:

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-02-06T19:31:30Z

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-azure

kubevirt-bot · 2023-02-06T19:31:33Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-azure

In response to this:

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

coveralls · 2023-02-07T10:20:00Z

Pull Request Test Coverage Report for Build 4128347350

6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.07%) to 85.152%

Files with Coverage Reduction	New Missed Lines	%
controllers/operands/operandHandler.go	1	84.34%

Totals
Change from base Build 4128237157:	0.07%
Covered Lines:	4915
Relevant Lines:	5772

💛 - Coveralls

hco-bot · 2023-02-07T11:41:41Z

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure
okd-hco-e2e-image-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-gcp

kubevirt-bot · 2023-02-07T11:41:45Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-azure, ci/prow/okd-hco-e2e-image-index-gcp

In response to this:

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure
okd-hco-e2e-image-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-02-07T12:11:23Z

hco-e2e-image-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-aws
hco-e2e-upgrade-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-azure
hco-e2e-upgrade-prev-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-aws

kubevirt-bot · 2023-02-07T12:11:28Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-sno-aws, ci/prow/hco-e2e-upgrade-index-sno-azure, ci/prow/hco-e2e-upgrade-prev-index-sno-aws

In response to this:

hco-e2e-image-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-aws
hco-e2e-upgrade-index-sno-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-azure
hco-e2e-upgrade-prev-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiraboschi · 2023-02-07T13:09:50Z

/retest

hco-bot · 2023-02-07T13:10:34Z

hco-e2e-image-index-azure, hco-e2e-image-index-gcp lanes succeeded.
/override ci/prow/hco-e2e-image-index-aws

kubevirt-bot · 2023-02-07T13:10:38Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-aws

In response to this:

hco-e2e-image-index-azure, hco-e2e-image-index-gcp lanes succeeded.
/override ci/prow/hco-e2e-image-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-02-07T13:43:13Z

hco-e2e-image-index-azure, hco-e2e-image-index-gcp lanes succeeded.
/override ci/prow/hco-e2e-image-index-aws

kubevirt-bot · 2023-02-07T13:43:19Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-aws

In response to this:

hco-e2e-image-index-azure, hco-e2e-image-index-gcp lanes succeeded.
/override ci/prow/hco-e2e-image-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-02-07T14:31:32Z

okd-hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-gcp

kubevirt-bot · 2023-02-07T14:31:37Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-upgrade-index-gcp

In response to this:

okd-hco-e2e-upgrade-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-02-07T15:51:26Z

hco-e2e-kv-smoke-gcp lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-azure

kubevirt-bot · 2023-02-07T15:51:32Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure

In response to this:

hco-e2e-kv-smoke-gcp lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sonarqubecloud · 2023-02-08T21:01:13Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

hco-bot · 2023-02-08T22:22:32Z

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp
okd-hco-e2e-image-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-gcp

kubevirt-bot · 2023-02-08T22:22:36Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-gcp, ci/prow/okd-hco-e2e-image-index-gcp

In response to this:

hco-e2e-image-index-aws lane succeeded.
/override ci/prow/hco-e2e-image-index-gcp
okd-hco-e2e-image-index-aws lane succeeded.
/override ci/prow/okd-hco-e2e-image-index-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-02-08T22:51:42Z

okd-hco-e2e-upgrade-index-gcp lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-aws

kubevirt-bot · 2023-02-08T22:51:45Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/okd-hco-e2e-upgrade-index-aws

In response to this:

okd-hco-e2e-upgrade-index-gcp lane succeeded.
/override ci/prow/okd-hco-e2e-upgrade-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-02-08T23:06:11Z

hco-e2e-upgrade-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-aws

kubevirt-bot · 2023-02-08T23:06:14Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-sno-aws

In response to this:

hco-e2e-upgrade-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-02-09T00:33:39Z

hco-e2e-image-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-aws

kubevirt-bot · 2023-02-09T00:33:43Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-image-index-sno-aws

In response to this:

hco-e2e-image-index-sno-azure lane succeeded.
/override ci/prow/hco-e2e-image-index-sno-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-02-09T02:08:30Z

hco-e2e-kv-smoke-gcp lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-azure

kubevirt-bot · 2023-02-09T02:08:33Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure

In response to this:

hco-e2e-kv-smoke-gcp lane succeeded.
/override ci/prow/hco-e2e-kv-smoke-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tiraboschi · 2023-02-09T09:30:48Z

/retest

openshift-ci · 2023-02-09T09:54:55Z

@tiraboschi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/hco-e2e-upgrade-index-sno-aws	`d914720`	link	false	`/test hco-e2e-upgrade-index-sno-aws`
ci/prow/okd-hco-e2e-upgrade-index-aws	`d914720`	link	true	`/test okd-hco-e2e-upgrade-index-aws`
ci/prow/hco-e2e-image-index-sno-aws	`d914720`	link	false	`/test hco-e2e-image-index-sno-aws`
ci/prow/hco-e2e-image-index-gcp	`d914720`	link	true	`/test hco-e2e-image-index-gcp`
ci/prow/hco-e2e-kv-smoke-azure	`d914720`	link	true	`/test hco-e2e-kv-smoke-azure`
ci/prow/hco-e2e-upgrade-index-aws	`d914720`	link	true	`/test hco-e2e-upgrade-index-aws`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

hco-bot · 2023-02-09T10:51:35Z

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

kubevirt-bot · 2023-02-09T10:51:52Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-index-azure

In response to this:

hco-e2e-upgrade-prev-index-aws lane succeeded.
/override ci/prow/hco-e2e-upgrade-prev-index-azure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hco-bot · 2023-02-09T11:32:52Z

hco-e2e-upgrade-index-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-aws

kubevirt-bot · 2023-02-09T11:32:56Z

@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-index-aws

In response to this:

hco-e2e-upgrade-index-azure lane succeeded.
/override ci/prow/hco-e2e-upgrade-index-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nunnatsa

/approve

kubevirt-bot · 2023-02-09T11:46:28Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [nunnatsa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tiraboschi · 2023-02-09T16:22:33Z

/cherry-pick release-1.8

kubevirt-bot · 2023-02-09T16:23:32Z

@tiraboschi: #2229 failed to apply on top of branch "release-1.8":

Applying: Introduce a new jsonpatch annotation for SSP
Using index info to reconstruct a base tree...
M	controllers/common/consts.go
M	controllers/hyperconverged/hyperconverged_controller.go
M	controllers/hyperconverged/hyperconverged_controller_test.go
M	controllers/operands/ssp.go
M	controllers/operands/ssp_test.go
M	docs/cluster-configuration.md
M	hack/prom-rule-ci/prom-rules-tests.yaml
M	pkg/webhooks/validator/validator_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/webhooks/validator/validator_test.go
CONFLICT (content): Merge conflict in pkg/webhooks/validator/validator_test.go
Auto-merging hack/prom-rule-ci/prom-rules-tests.yaml
Auto-merging docs/cluster-configuration.md
Auto-merging controllers/operands/ssp_test.go
Auto-merging controllers/operands/ssp.go
Auto-merging controllers/hyperconverged/hyperconverged_controller_test.go
Auto-merging controllers/hyperconverged/hyperconverged_controller.go
Auto-merging controllers/common/consts.go
CONFLICT (content): Merge conflict in controllers/common/consts.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Introduce a new jsonpatch annotation for SSP
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

…2229) Introduce an additional jsonpatch annotation to let the cluster admin override also SSP configuration for test/dev purposes. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2166923 JIRA-ticket: https://issues.redhat.com/browse/CNV-25035 This is a manual cherry-pick of kubevirt#2229 Signed-off-by: Simone Tiraboschi <[email protected]>

…2240) Introduce an additional jsonpatch annotation to let the cluster admin override also SSP configuration for test/dev purposes. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2166923 JIRA-ticket: https://issues.redhat.com/browse/CNV-25035 This is a manual cherry-pick of #2229 Signed-off-by: Simone Tiraboschi <[email protected]>

kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Feb 6, 2023

kubevirt-bot requested review from machadovilaca and nunnatsa February 6, 2023 17:15

kubevirt-bot added the size/L label Feb 6, 2023

tiraboschi force-pushed the ssp_json branch 2 times, most recently from b9e6a93 to 1258528 Compare February 6, 2023 17:23

tiraboschi force-pushed the ssp_json branch from 1258528 to 52921cb Compare February 7, 2023 10:14

nunnatsa approved these changes Feb 9, 2023

View reviewed changes

kubevirt-bot assigned nunnatsa Feb 9, 2023

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2023

kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2023

kubevirt-bot merged commit 481b37c into kubevirt:main Feb 9, 2023

tiraboschi deleted the ssp_json branch February 9, 2023 16:22

tiraboschi mentioned this pull request Feb 9, 2023

[release-1.8] Introduce a new jsonpatch annotation for SSP (#2229) #2240

Merged

11 tasks

Introduce a new jsonpatch annotation for SSP #2229

Introduce a new jsonpatch annotation for SSP #2229

Conversation

tiraboschi commented Feb 6, 2023

hco-bot commented Feb 6, 2023

kubevirt-bot commented Feb 6, 2023

hco-bot commented Feb 6, 2023

kubevirt-bot commented Feb 6, 2023

hco-bot commented Feb 6, 2023

kubevirt-bot commented Feb 6, 2023

hco-bot commented Feb 6, 2023

kubevirt-bot commented Feb 6, 2023

coveralls commented Feb 7, 2023 • edited Loading

Pull Request Test Coverage Report for Build 4128347350

💛 - Coveralls

hco-bot commented Feb 7, 2023

kubevirt-bot commented Feb 7, 2023

hco-bot commented Feb 7, 2023

kubevirt-bot commented Feb 7, 2023

tiraboschi commented Feb 7, 2023

hco-bot commented Feb 7, 2023

kubevirt-bot commented Feb 7, 2023

hco-bot commented Feb 7, 2023

kubevirt-bot commented Feb 7, 2023

hco-bot commented Feb 7, 2023

kubevirt-bot commented Feb 7, 2023

hco-bot commented Feb 7, 2023

kubevirt-bot commented Feb 7, 2023

sonarqubecloud bot commented Feb 8, 2023

hco-bot commented Feb 8, 2023

kubevirt-bot commented Feb 8, 2023

hco-bot commented Feb 8, 2023

kubevirt-bot commented Feb 8, 2023

hco-bot commented Feb 8, 2023

kubevirt-bot commented Feb 8, 2023

hco-bot commented Feb 9, 2023

kubevirt-bot commented Feb 9, 2023

hco-bot commented Feb 9, 2023

kubevirt-bot commented Feb 9, 2023

tiraboschi commented Feb 9, 2023

openshift-ci bot commented Feb 9, 2023 • edited Loading

hco-bot commented Feb 9, 2023

kubevirt-bot commented Feb 9, 2023

hco-bot commented Feb 9, 2023

kubevirt-bot commented Feb 9, 2023

nunnatsa left a comment

Choose a reason for hiding this comment

kubevirt-bot commented Feb 9, 2023

tiraboschi commented Feb 9, 2023

kubevirt-bot commented Feb 9, 2023

coveralls commented Feb 7, 2023 •

edited

Loading

openshift-ci bot commented Feb 9, 2023 •

edited

Loading