Reconcile MTQ CR according to an HCO FeatureGate #2473
Conversation
kubevirt-bot
added
release-note
orenc1
force-pushed
the
reconcile_mtq_cr
branch
from
c641755 to
b2c427f
Compare
orenc1
changed the title
kubevirt-bot
added
the
do-not-merge/work-in-progress
controllers/operands/mtq.go
Outdated
| "github.com/kubevirt/hyperconverged-cluster-operator/controllers/common" | ||
| "github.com/kubevirt/hyperconverged-cluster-operator/pkg/util" | ||
| hcoutil "github.com/kubevirt/hyperconverged-cluster-operator/pkg/util" | ||
| mtqv1alpha1 "kubevirt.io/managed-tenant-quota-api/pkg/apis/core/v1alpha1" |
There was a problem hiding this comment.
Thanks for this PR please change to :
mtqv1alpha1 "kubevirt.io/managed-tenant-quota/staging/src/kubevirt.io/managed-tenant-quota-api/pkg/apis/core/v1alpha1"
go.mod
Outdated
| @@ -36,6 +36,7 @@ require ( | |||
| kubevirt.io/api v1.0.0 | |||
| kubevirt.io/containerized-data-importer-api v1.57.0-rc1 | |||
| kubevirt.io/controller-lifecycle-operator-sdk/api v0.2.4 | |||
| kubevirt.io/managed-tenant-quota-api v1.1.0 | |||
There was a problem hiding this comment.
actually we didn't create api repo yet please change to:
kubevirt.io/managed-tenant-quota v1.1.0
nunnatsa
force-pushed
the
reconcile_mtq_cr
branch
4 times, most recently
from
fe5813c to
9f8c975
Compare
Pull Request Test Coverage Report for Build 5853808040
💛 - Coveralls |
orenc1
force-pushed
the
reconcile_mtq_cr
branch
2 times, most recently
from
1b3f219 to
c3910ef
Compare
kubevirt-bot
added
the
needs-rebase
orenc1
force-pushed
the
reconcile_mtq_cr
branch
from
c3910ef to
e47bc71
Compare
kubevirt-bot
removed
the
needs-rebase
orenc1
force-pushed
the
reconcile_mtq_cr
branch
from
e47bc71 to
3ef0f08
Compare
nunnatsa
force-pushed
the
reconcile_mtq_cr
branch
from
3ef0f08 to
c743a28
Compare
nunnatsa
force-pushed
the
reconcile_mtq_cr
branch
3 times, most recently
from
1ac0fc5 to
c210311
Compare
|
/retest |
nunnatsa
force-pushed
the
reconcile_mtq_cr
branch
2 times, most recently
from
7a245d5 to
ba64257
Compare
|
okd-hco-e2e-upgrade-operator-sdk-aws lane succeeded. |
|
/lgtm |
|
/retest |
|
okd-hco-e2e-operator-sdk-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-operator-sdk-azure, ci/prow/okd-hco-e2e-operator-sdk-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test hco-e2e-upgrade-prev-operator-sdk-azure |
|
@nunnatsa: The specified target(s) for
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-operator-sdk-sno-azure lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-sno-aws, ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nunnatsa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
hco-e2e-operator-sdk-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-upgrade-prev-operator-sdk-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure, ci/prow/okd-hco-e2e-upgrade-operator-sdk-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
hco-e2e-upgrade-prev-operator-sdk-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-operator-sdk-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@orenc1: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
hco-e2e-kv-smoke-gcp lane passed /cherry-pick release-1.10 |
1 similar comment
|
hco-e2e-kv-smoke-gcp lane passed /cherry-pick release-1.10 |
|
@nunnatsa: once the present PR merges, I will cherry-pick it on top of release-1.10 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@nunnatsa: Overrode contexts on behalf of nunnatsa: ci/prow/hco-e2e-kv-smoke-azure, ci/prow/hco-e2e-upgrade-operator-sdk-azure, ci/prow/okd-hco-e2e-operator-sdk-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@nunnatsa: #2473 failed to apply on top of branch "release-1.10": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Rebase Bot action has failed. |
|
@nunnatsa: Overrode contexts on behalf of nunnatsa: ci/prow/hco-e2e-kv-smoke-azure, ci/prow/hco-e2e-upgrade-operator-sdk-azure, ci/prow/okd-hco-e2e-operator-sdk-gcp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
If hco's .spec.featureGates.enableManagedTenantQuota=true, the MTQ CustomResource will be deployed in the installation namespace. When the feature gate is changed to 'false', the CR is deleted. Signed-off-by: Oren Cohen <[email protected]>
If hco's .spec.featureGates.enableManagedTenantQuota=true, the MTQ CustomResource will be deployed in the installation namespace. When the feature gate is changed to 'false', the CR is deleted. Signed-off-by: Oren Cohen <[email protected]> Co-authored-by: Oren Cohen <[email protected]>
If hco's
.spec.featureGates.enableManagedTenantQuota=true, the MTQ CustomResource will be deployed in the installation namespace. When the feature gate is changed tofalse, the CR is deleted.The feature is in Dev Preview (DP) and it is in opt-in mode (disabled by default).
What this PR does / why we need it:
Reviewer Checklist
Jira Ticket:
Release note: